Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move lang files for search plugin #334

Merged
merged 7 commits into from
Mar 25, 2017
Merged

Move lang files for search plugin #334

merged 7 commits into from
Mar 25, 2017

Conversation

zero-24
Copy link
Contributor

@zero-24 zero-24 commented Mar 24, 2017

Pull Request for Issue #290

Summary of Changes

Move language files for the search plugin into the plugin distribution file. This makes all the plugins consistent in not putting language files into administrator/language.

Testing Instructions

  • Install 3.7.0b2
  • apply this patch
  • confirm the language files in the plugins folder

Expected result

the language files in the plugins folder

Actual result

the language files are not in the plugins folder

Documentation Changes Required

None

@zero-24 zero-24 added this to the 3.7.0 milestone Mar 24, 2017
@ghost
Copy link

ghost commented Mar 24, 2017

Install 3.7.0b2

"3.7.0b2" is the latest staging (=weblinks.master.zip)?

@zero-24
Copy link
Contributor Author

zero-24 commented Mar 24, 2017

3.7.0b2 means the CMS not the weblinks ;)

@ghost
Copy link

ghost commented Mar 24, 2017

i have 3.7.0-rc1 (neweset nightly build) installed. Can i test on this?

@infograf768
Copy link
Contributor

I have no problem with this if we keep putting the lang files in the admin part in the CMS.
If any change has been done for weblinks where lang files are not put into the admin or site main languages folders, please revert!

@zero-24
Copy link
Contributor Author

zero-24 commented Mar 24, 2017

Yes @franz-wohlkoenig

Yes @infograf768 that is the plan.

@infograf768
Copy link
Contributor

tks for reply.

@zero-24
Copy link
Contributor Author

zero-24 commented Mar 24, 2017

This is just to clean up the repo here ;)

@ghost
Copy link

ghost commented Mar 24, 2017

I have tested this item ✅ successfully on 64d246f

After PR are Lang.-Files in Folder:
bildschirmfoto 2017-03-24 um 18 47 33


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/weblinks/334.

@yvesh yvesh merged commit 300460a into joomla-extensions:master Mar 25, 2017
@yvesh
Copy link
Member

yvesh commented Mar 25, 2017

Thank you @zero-24

@zero-24 zero-24 deleted the move_language branch March 25, 2017 11:29
@zero-24
Copy link
Contributor Author

zero-24 commented Mar 25, 2017

Thanks @yvesh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants