Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.3] Guided Tours replace deprecated access of input property #40305

Merged

Conversation

heelc29
Copy link
Contributor

@heelc29 heelc29 commented Apr 2, 2023

Summary of Changes

Apply changes from #39029 for guided tours

Testing Instructions

  • save a tour
  • open tour edit form
  • open step edit form
  • check module (mod_guidedtours)

Actual result BEFORE applying this Pull Request

Use of deprecated access to the application's input property

Expected result AFTER applying this Pull Request

All works like before, but without using deprecated access to the application's input property

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed
  • No documentation changes for manual.joomla.org needed

@joomdonation
Copy link
Contributor

I have tested this item ✅ successfully on 3a45fa7


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40305.

@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on 3a45fa7


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40305.

@alikon
Copy link
Contributor

alikon commented Apr 3, 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40305.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Apr 3, 2023
@Hackwar Hackwar added the bug label Apr 8, 2023
@obuisard obuisard merged commit 60d1bc0 into joomla:4.3-dev May 5, 2023
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label May 5, 2023
@obuisard obuisard added this to the Joomla! 4.3.2 milestone May 5, 2023
@obuisard
Copy link
Contributor

obuisard commented May 5, 2023

Thank you @heelc29 for the PR :-)

@heelc29 heelc29 deleted the 4.3/com_guidedtours/application-input branch May 19, 2023 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants