Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.3] Change application input access to getInput #39029

Merged
merged 3 commits into from
Oct 23, 2022

Conversation

laoneo
Copy link
Member

@laoneo laoneo commented Oct 22, 2022

Summary of Changes

As directly access the input variable is deprecated since Joomla 4.0 in #28313, the core should not use it anymore. This pr changes the call to the getInput function.

Testing Instructions

Open the back or front end.

Actual result BEFORE applying this Pull Request

All works.

Expected result AFTER applying this Pull Request

All works.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

plugins/system/privacyconsent/privacyconsent.php Outdated Show resolved Hide resolved
plugins/system/privacyconsent/privacyconsent.php Outdated Show resolved Hide resolved
plugins/user/terms/terms.php Outdated Show resolved Hide resolved
templates/cassiopeia/error.php Outdated Show resolved Hide resolved
templates/cassiopeia/index.php Outdated Show resolved Hide resolved
Co-authored-by: Harald Leithner <leithner@itronic.at>
@HLeithner HLeithner merged commit 7f20b06 into joomla:4.3-dev Oct 23, 2022
@HLeithner
Copy link
Member

Thanks, there is still room for improvements but it's more important to now use deprecated functions for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants