-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.0] %s for strings/floats in sprintf #41740
Conversation
I have tested this item ✅ successfully on 081e913 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41740. |
1 similar comment
I have tested this item ✅ successfully on 081e913 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41740. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41740. |
Rather than string can we use |
does %f work @heelc29 ? |
The first one com_finder.ini: No because it is a string - see https://www.php.net/manual/en/function.number-format.php The others: There is a different for number of digits to be printed after the decimal point (by default, this is 6) https://www.php.net/manual/en/function.sprintf.php Example:
|
I merge this for now |
Pull Request for Issue #41710 .
Summary of Changes
revert parts from #41710
@brianteeman @HLeithner
com_finder: uses
number_format
joomla-cms/administrator/components/com_finder/tmpl/statistics/default.php
Line 18 in d3589c9
plg_content_vote: is float
joomla-cms/plugins/content/vote/tmpl/rating.php
Lines 53 to 58 in d3589c9
finderindex: uses round
joomla-cms/libraries/src/Console/FinderIndexCommand.php
Line 403 in d3589c9
Testing Instructions
com_finder/statistics: values above 1000
plg_content_vote: two votes (5+4)/2=4.5
finderindex: run cli/joomla.php findex:index
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select: