Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.0] %d not %s for integer in sprintf #2993

Merged
merged 5 commits into from
Sep 15, 2023
Merged

[5.0] %d not %s for integer in sprintf #2993

merged 5 commits into from
Sep 15, 2023

Conversation

tecpromotion
Copy link
Member

Pull Request für Issue #2983 .

Zusammenfassung der Änderungen

%d not %s for integer in sprintf

Wo wird der Sprachstring angezeigt / Wie kann getestet werden

backend
frontend

@tecpromotion tecpromotion requested review from a team, zero-24 and heelc29 and removed request for a team September 13, 2023 11:28
@tecpromotion tecpromotion self-assigned this Sep 13, 2023
@tecpromotion tecpromotion added this to the 5.0.0v1 milestone Sep 13, 2023
@tecpromotion tecpromotion linked an issue Sep 13, 2023 that may be closed by this pull request
[5.0] %d not %s for integer in sprintf #2983
Closed
heelc29
heelc29 requested changes Sep 13, 2023
View reviewed changes
Copy link
Member

@heelc29 heelc29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

siehe joomla/joomla-cms#41740

language/de-DE/finder_cli.ini Outdated Show resolved Hide resolved
administrator/language/de-DE/com_finder.ini Outdated Show resolved Hide resolved
administrator/language/de-DE/plg_content_vote.ini Outdated Show resolved Hide resolved
@tecpromotion @heelc29
Apply suggestions from code review
da85ea4 
Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com>
@tecpromotion tecpromotion linked an issue Sep 14, 2023 that may be closed by this pull request
[5.0] %s for strings/floats in sprintf #2994
Closed
@tecpromotion
Copy link
Member Author

RTC

heelc29
heelc29 approved these changes Sep 15, 2023
View reviewed changes
Copy link
Member

@heelc29 heelc29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
image
image
image
image
image
image
image
image
image
image

@heelc29 heelc29 merged commit 9ddcd35 into joomlagerman:5.0-dev Sep 15, 2023
@heelc29
Copy link
Member

heelc29 commented Sep 15, 2023

Danke

@tecpromotion tecpromotion deleted the issue-2983 branch September 25, 2023 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heelc29 heelc29 heelc29 approved these changes

@zero-24 zero-24 Awaiting requested review from zero-24 zero-24 was automatically assigned from joomlagerman/maintainers

Assignees

@tecpromotion tecpromotion

Labels
core language change Joomla! 5.x
Milestone
5.0.0v1
Development

Successfully merging this pull request may close these issues.

[5.0] %s for strings/floats in sprintf [5.0] %d not %s for integer in sprintf
2 participants
@tecpromotion @heelc29