Fixed lone number support #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 99.62% // Head: 99.63% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #13 +/- ##
=======================================
Coverage 99.62% 99.63%
=======================================
Files 9 9
Lines 268 272 +4
=======================================
+ Hits 267 271 +4
Misses 1 1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Awesome! Thanks a lot! I will merge this and cut a patch release so it is propagated upstream. |
|
Released as 0.4.1. Thanks again! |
|
Awesome, thanks for the quick response! |
This was referenced Sep 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm glad to see the benchmarking and performance improvements of this library over
serde_json. When working on updating pola-rs/polars#3413, I noticed that changes in jorgecarleitao/arrow2#1024 had broken support for deserializing numbers on their own (outside of JSON lists or objects). This PR fixes the root cause in the number parsing code, and provides parity withserde_jsonsupport of lone numbers.I'm hoping to incorporate these changes into pola-rs/polars#3413, so an update to arrow2 would also be greatly appreciated! 😄