Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed parsing lone numbers #14

Merged
merged 1 commit into from
Oct 4, 2022

Conversation

cjermain
Copy link
Collaborator

This PR follows #13, which addressed issues with numbers on their own failing to deserialized. That solution was only a partial fix, because the tests were not rigorous enough to assert that the values were correct. 😞 I've updated the tests to explicitly assert the values are correct, and realized I had been missing the number_end increment, which was causing the numbers to be truncated. I reordered the operations in parse_number to fix that.

@codecov
Copy link

codecov bot commented Sep 28, 2022

Codecov Report

Base: 99.63% // Head: 99.63% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (5a954fa) compared to base (b3d44a3).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #14   +/-   ##
=======================================
  Coverage   99.63%   99.63%           
=======================================
  Files           9        9           
  Lines         272      273    +1     
=======================================
+ Hits          271      272    +1     
  Misses          1        1           
Impacted Files Coverage Δ
src/number.rs 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jorgecarleitao jorgecarleitao changed the title Fixing lone number values (take 2) Fixed parsing lone numbers Oct 4, 2022
@jorgecarleitao jorgecarleitao merged commit dc7b0f5 into jorgecarleitao:main Oct 4, 2022
@jorgecarleitao jorgecarleitao added the bug Something isn't working label Oct 4, 2022
@cjermain cjermain deleted the fix_lone_numbers2 branch October 4, 2022 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants