Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

native: add IsBigEndian bool const #3

Merged
merged 1 commit into from
Dec 13, 2022
Merged

native: add IsBigEndian bool const #3

merged 1 commit into from
Dec 13, 2022

Conversation

bradfitz
Copy link
Collaborator

@bradfitz
Copy link
Collaborator Author

cc @mdlayher

mdlayher
mdlayher approved these changes Dec 13, 2022
View reviewed changes
Copy link
Collaborator

@mdlayher mdlayher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

josharian
josharian approved these changes Dec 13, 2022
View reviewed changes
Copy link
Owner

@josharian josharian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@josharian josharian merged commit c1e37c0 into josharian:main Dec 13, 2022
bradfitz added a commit to tailscale/tailscale that referenced this pull request Dec 13, 2022
@bradfitz
util/endian: delete package; use updated josharian/native instead
7f9a1a3 
See josharian/native#3

Updates golang/go#57237

Change-Id: I238c04c6654e5b9e7d9cfb81a7bbc5e1043a84a2
Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
This was referenced Dec 13, 2022
Merged
Closed
bradfitz added a commit to tailscale/tailscale that referenced this pull request Dec 13, 2022
@bradfitz
util/endian: delete package; use updated josharian/native instead
ca08e31 
See josharian/native#3

Updates golang/go#57237

Change-Id: I238c04c6654e5b9e7d9cfb81a7bbc5e1043a84a2
Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
@mdlayher
Copy link
Collaborator

As a FYI, I have tagged v1.1.0 for Go module purposes.

coadler pushed a commit to coder/tailscale that referenced this pull request Feb 2, 2023
@bradfitz @coadler
util/endian: delete package; use updated josharian/native instead
2978540 
See josharian/native#3

Updates golang/go#57237

Change-Id: I238c04c6654e5b9e7d9cfb81a7bbc5e1043a84a2
Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josharian josharian josharian approved these changes

@mdlayher mdlayher mdlayher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bradfitz @mdlayher @josharian