-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to josharian/native for native endian? #7
Comments
Oh, I guess we can't outright remove it, as it has a bunch of callers, like But you could use the constant in a And you could update the docs to point people at the |
Indeed I could, just say the word. |
Fixes u-root#7 Updates golang/go#57237 Signed-off-by: Brad Fitzpatrick <brad@danga.com>
Fixes #7 Updates golang/go#57237 Signed-off-by: Brad Fitzpatrick <brad@danga.com>
No need for co-maintainership, I'm happy with this. Thanks! |
If you go make a PR to update dhcp, I'll be happy to approve that as well. |
Done: insomniacslk/dhcp#484 |
@hugelgupf, any chance this repo could switch to using https://pkg.go.dev/github.com/josharian/native
@josharian and I are trying to reduce the number of copies of this code in the Go ecosystem, per golang/go#57237
As of josharian/native#3 it has both a boolean const and a binary.ByteOrder var.
It also has a fallback to runtime-based detection if build tags get stale in the future.
If you're concerned about lacking control, I'm sure @josharian could grant you co-maintainership of the native repo.
Happy to send you a PR if you're cool with it. Or you can.
The text was updated successfully, but these errors were encountered: