Merge pull request #36 from dkarrasch/chol

Remove pivot argument w/ default value in cholesky!
joshday · Dec 13, 2021 · a410103 · a410103
2 parents d56bb5d + 28e356a
commit a410103
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 5 deletions.
diff --git a/Project.toml b/Project.toml
@@ -1,6 +1,6 @@
 name = "SparseRegression"
 uuid = "ca6142a6-a6a7-57f5-b674-4a8484b22e92"
-version = "0.2.0"
+version = "0.2.1"
 
 [deps]
 LearnBase = "7f8f8fb0-2700-5f03-b4bd-41f8cfc144b6"

diff --git a/appveyor.yml b/appveyor.yml
@@ -1,7 +1,8 @@
 environment:
   matrix:
-  - julia_version: 1.0
-  - julia_version: 1.1
+  - julia_version: 1.2
+  - julia_version: 1.6
+  - julia_version: 1
   - julia_version: nightly
 
 platform:
@@ -32,4 +33,4 @@ build_script:
 
 test_script:
   - echo "%JL_TEST_SCRIPT%"
-  - C:\julia\bin\julia -e "%JL_TEST_SCRIPT%"
+  - C:\julia\bin\julia -e "%JL_TEST_SCRIPT%"
diff --git a/src/algorithms/algorithms.jl b/src/algorithms/algorithms.jl
@@ -268,6 +268,6 @@ Base.show(io::IO, a::LinRegCholesky) = print(io, "LinRegCholesky")
 function update!(o::SModel, a::LinRegCholesky)
     copyto!(a.S, a.A)
     add_ridge!(o, a)
-    cholesky!(Symmetric(a.S), Val(false))
+    cholesky!(Symmetric(a.S))
     @views o.β[:] = UpperTriangular(a.S[1:end-1, 1:end-1]) \ a.S[1:end-1, end]
 end