Remove pivot argument w/ default value in cholesky! #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing the explicit
Val(false)avoids getting depwarns due to the upcoming JuliaLang/julia#41640. Constant propagation (of the default value) should prevent any performance or type inference regression. This PR does not need to wait for the Julia PR to be merged. Another option would to be have aVERSION-dependent definition ofnopivot_cholesky!(A)that expands to eithercholesky!(A, Val(false))orcholesky!(A, NoPivot()).I'm not sure though that this prevents the error in the pkg eval run https://s3.amazonaws.com/julialang-reports/nanosoldier/pkgeval/by_hash/d6eba05_vs_63f5b8a/SparseRegression.1.8.0-DEV-96875a2ac12.log