Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

フロントデザイン変更 #43

Merged
merged 1 commit into from
Oct 27, 2024
Merged

フロントデザイン変更 #43

merged 1 commit into from
Oct 27, 2024

Conversation

MurakawaTakuya
Copy link
Contributor

@MurakawaTakuya MurakawaTakuya commented Oct 27, 2024 •
edited
Loading

Closes

概要

  • headerデザイン変更
  • フォントを追加
  • アイコンを追加
  • その他文言を修正
before after
image image

変更内容

確認方法

チェックリスト

  • File Changedで不要な変更や誤った変更が無いか確認した
  • 機密情報が含まれていないことを確認した(含まれている場合は直ちにリモートからコミットを削除すること)
  • UIを変更した場合
    • PCで見た時に表示が崩れていないことを確認した
    • スマホでも正常に表示されることを確認した(大きい画面と小さい画面両方で)

@MurakawaTakuya MurakawaTakuya self-assigned this Oct 27, 2024
@MurakawaTakuya MurakawaTakuya requested review from ViniciusBrJp and senntou and removed request for ViniciusBrJp October 27, 2024 01:16
ViniciusBrJp
ViniciusBrJp approved these changes Oct 27, 2024
View reviewed changes
Copy link
Collaborator

@ViniciusBrJp ViniciusBrJp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

senntou
senntou approved these changes Oct 27, 2024
View reviewed changes
Copy link
Collaborator

@senntou senntou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@senntou senntou merged commit 885aae2 into main Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ViniciusBrJp ViniciusBrJp ViniciusBrJp approved these changes

@senntou senntou senntou approved these changes

Assignees

@MurakawaTakuya MurakawaTakuya

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MurakawaTakuya @senntou @ViniciusBrJp