Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Headerにユーザー数表示 #44

Merged
merged 3 commits into from
Oct 27, 2024
Merged

Headerにユーザー数表示 #44

merged 3 commits into from
Oct 27, 2024

Conversation

ViniciusBrJp
Copy link
Collaborator

@ViniciusBrJp ViniciusBrJp commented Oct 27, 2024

Closes headerにusersの人数表示と名前一覧のモーダルを作成 #40

概要

変更内容

確認方法

チェックリスト

  • File Changedで不要な変更や誤った変更が無いか確認した
  • 機密情報が含まれていないことを確認した(含まれている場合は直ちにリモートからコミットを削除すること)
  • UIを変更した場合
    • PCで見た時に表示が崩れていないことを確認した
    • スマホでも正常に表示されることを確認した(大きい画面と小さい画面両方で)

@ViniciusBrJp ViniciusBrJp self-assigned this Oct 27, 2024
@senntou senntou force-pushed the feat/40-user-number branch from 280eb05 to 2df2e7f Compare October 27, 2024 03:28
@senntou senntou marked this pull request as ready for review October 27, 2024 03:29
@senntou senntou force-pushed the feat/40-user-number branch from 2df2e7f to 304516d Compare October 27, 2024 03:32
Copy link
Contributor

@MurakawaTakuya MurakawaTakuya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ViniciusBrJp ViniciusBrJp merged commit 91a571a into main Oct 27, 2024
@MurakawaTakuya MurakawaTakuya mentioned this pull request Oct 27, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

headerにusersの人数表示と名前一覧のモーダルを作成
2 participants