Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updateメッセージを全員に送られるバグを修正 #46

Merged
merged 1 commit into from
Oct 27, 2024
Merged

updateメッセージを全員に送られるバグを修正 #46

merged 1 commit into from
Oct 27, 2024
+6 −4

Conversation

senntou
Copy link
Collaborator

@senntou senntou commented Oct 27, 2024 •
edited by MurakawaTakuya
Loading

Closes

概要

  • updateメッセージが全員に送られていたのでグループ内の人だけに送られるように修正

変更内容

確認方法

チェックリスト

  • File Changedで不要な変更や誤った変更が無いか確認した
  • 機密情報が含まれていないことを確認した(含まれている場合は直ちにリモートからコミットを削除すること)
  • UIを変更した場合
    • PCで見た時に表示が崩れていないことを確認した
    • スマホでも正常に表示されることを確認した(大きい画面と小さい画面両方で)

@senntou senntou self-assigned this Oct 27, 2024
MurakawaTakuya
MurakawaTakuya approved these changes Oct 27, 2024
View reviewed changes
Copy link
Contributor

@MurakawaTakuya MurakawaTakuya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MurakawaTakuya MurakawaTakuya merged commit b09a319 into main Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MurakawaTakuya MurakawaTakuya MurakawaTakuya approved these changes

@ViniciusBrJp ViniciusBrJp Awaiting requested review from ViniciusBrJp

Assignees

@senntou senntou

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@senntou @MurakawaTakuya