Remap tsconfig for builds so that only files under src are considered (…

…#212)

Co-authored-by: Luke Sheard <luke.sheard@jpmorgan.com>

.changeset/wet-nails-care.md

@@ -0,0 +1,6 @@
+---
+'modular-scripts': patch
+---
+
+Fix an issue where generated files from libraries would interfere with
+typescript definition generation

packages/create-modular-react-app/src/__tests__/index.test.ts

@@ -91,7 +91,7 @@ describe('create-modular-react-app', () => {
       │     │  ├─ logo.svg #1okqmlj
       │     │  └─ react-app-env.d.ts #1dm2mq6
       │     └─ tsconfig.json #6rw46b
-      ├─ tsconfig.json #7rtj5f
+      ├─ tsconfig.json #xubky9
       └─ yarn.lock"
     `);
     expect(

packages/create-modular-react-app/template/tsconfig.json

@@ -1,4 +1,4 @@
 {
   "extends": "modular-scripts/tsconfig.json",
-  "include": ["packages"]
+  "include": ["modular", "packages/*/src"]
 }

packages/modular-scripts/src/build.ts

@@ -534,7 +534,10 @@ function makeTypings(directoryName: string) {
   };
 
   // then add our custom stuff
-  tsconfig.include = [`${packagesRoot}/${directoryName}`];
+
+  // Only include src files from the package to prevent already built
+  // files from interferring with the compile
+  tsconfig.include = [`${packagesRoot}/${directoryName}/src`];
   tsconfig.compilerOptions = {
     ...tsconfig.compilerOptions,
     declarationDir: `${packagesRoot}/${directoryName}/${outputDirectory}-types`,

packages/tree-view-for-tests/src/__tests__/tree.test.ts

@@ -15,7 +15,7 @@ test('it can serialise a folder', () => {
     ├─ package.json
     ├─ src
     │  ├─ __tests__
-    │  │  └─ index.test.ts #1ekksvp
+    │  │  └─ index.test.ts #1v8shn0
     │  ├─ cli.ts #gcx3cm
     │  └─ index.ts #un0l9d
     └─ template
@@ -30,6 +30,6 @@ test('it can serialise a folder', () => {
        │  └─ setupTests.ts #bnjknz
        ├─ packages
        │  └─ README.md #14bthrh
-       └─ tsconfig.json #7rtj5f"
+       └─ tsconfig.json #xubky9"
   `);
 });