Restrict tsconfig files so that TypeScript files live in src for packages
#212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 579e35f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The fix should be to exclude /dist folders, which I've done in my PR. |
|
I think restricting the included files is a better fix - since it minimizes the files to filter upfront. |
|
That's a different conversation to have then, because that implies also changing the tsconfig, ad saying we should only have .ts(x) files under src. Which we can totally consider, but isn't the right fix for this specific purpose. |
LukeSheard
force-pushed
the
build-fixes
branch
from
e4c1447
to
6be4085
Compare
LukeSheard
changed the title
src for packages
LukeSheard
force-pushed
the
build-fixes
branch
from
6be4085
to
9a5bc4f
Compare
LukeSheard
force-pushed
the
build-fixes
branch
from
5925c50
to
d65cf6c
Compare
|
Pass CI and I'll stamp this? |
LukeSheard
force-pushed
the
build-fixes
branch
from
d65cf6c
to
6b71e4c
Compare
LukeSheard
force-pushed
the
build-fixes
branch
from
6b71e4c
to
579e35f
Compare
threepointone
approved these changes
Jan 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR restricts the location of TypeScript files into the
srcdirectory for each package to prevent erroneous files being picked up by type checking and build scripts. This is the beginning of imposing sensible defaults for the modular environment.After replacing the JPM build script that we had pre
modular buildI came across this bug when trying to generate typescript files. Since the include is set so broadly it will start picking up generateddistfiles and fail. I edited the file locally to test and it works fine.