Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for ssize_t issue on windows #1011

Merged
merged 4 commits into from
Nov 2, 2021
Merged

Conversation

Thrameos
Copy link
Contributor

Fixes #1009

@codecov
Copy link

codecov bot commented Oct 17, 2021

Codecov Report

Merging #1011 (9325d37) into master (83c7fe6) will increase coverage by 1.55%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1011      +/-   ##
==========================================
+ Coverage   87.53%   89.09%   +1.55%     
==========================================
  Files         114      112       -2     
  Lines       10076    10039      -37     
  Branches     4063     3968      -95     
==========================================
+ Hits         8820     8944     +124     
- Misses        642      660      +18     
+ Partials      614      435     -179     
Impacted Files Coverage Δ
native/common/include/jp_booleantype.h 100.00% <ø> (ø)
native/common/include/jp_bytetype.h 100.00% <ø> (ø)
native/common/include/jp_chartype.h 100.00% <ø> (ø)
native/common/include/jp_doubletype.h 100.00% <ø> (ø)
native/common/include/jp_floattype.h 100.00% <ø> (ø)
native/common/include/jp_inttype.h 100.00% <ø> (ø)
native/common/include/jp_longtype.h 100.00% <ø> (ø)
native/common/include/jp_primitivetype.h 100.00% <ø> (ø)
native/common/include/jp_shorttype.h 100.00% <ø> (ø)
native/common/include/jp_voidtype.h 100.00% <ø> (ø)
... and 62 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83c7fe6...9325d37. Read the comment docs.

@Thrameos Thrameos requested a review from marscher October 18, 2021 23:38
@Thrameos Thrameos added the bug Unable to deliver desired behavior (crash, fail, untested) label Oct 18, 2021
@Thrameos Thrameos self-assigned this Oct 18, 2021
@marscher
Copy link
Member

Thanks! What about the CI, no build job run successfully?

@Thrameos
Copy link
Contributor Author

Not sure why the CI aborted. But the coverage ran so it must have completed.

We would have to add another push to see if it runs again.

@Thrameos
Copy link
Contributor Author

The image on the CI we were using disappeared (ubuntu-16). I will have to update it to what it needs. Not sure how many passes it will take.

@Thrameos
Copy link
Contributor Author

Okay should be ready to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Unable to deliver desired behavior (crash, fail, untested)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot install under Python 3.10
2 participants