-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for ssize_t issue on windows #1011
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1011 +/- ##
==========================================
+ Coverage 87.53% 89.09% +1.55%
==========================================
Files 114 112 -2
Lines 10076 10039 -37
Branches 4063 3968 -95
==========================================
+ Hits 8820 8944 +124
- Misses 642 660 +18
+ Partials 614 435 -179
Continue to review full report at Codecov.
|
Thanks! What about the CI, no build job run successfully? |
Not sure why the CI aborted. But the coverage ran so it must have completed. We would have to add another push to see if it runs again. |
The image on the CI we were using disappeared (ubuntu-16). I will have to update it to what it needs. Not sure how many passes it will take. |
Okay should be ready to go. |
Fixes #1009