Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: switch to Sass for styles #1313

Merged
merged 21 commits into from
May 9, 2019
Merged

feat: switch to Sass for styles #1313

merged 21 commits into from
May 9, 2019

Conversation

cutterbl
Copy link
Collaborator

@cutterbl cutterbl commented May 8, 2019 •
edited
Loading

Updates to component styling. Includes all code from PR #1235 .

  • Build Process (remove LESS and include autoprefixer)
  • Examples
  • Storybook
  • README
  • Examples Into

cutterbl and others added 20 commits February 22, 2019 08:47
@cutterbl
Provide SASS implementation of styles
da31e4e
@cutterbl
Merge pull request #1 from intljusticemission/master
f7b48fe 
merge of latest head changes
@cutterbl
Merge pull request #3 from intljusticemission/master
50f71cb 
merging latest from base project
@cutterbl
Merge pull request #4 from intljusticemission/master
681bedc 
chore: upgrade storybook (jquense#1308)
@cutterbl
Remove duplicate style for parity with the LESS implementation from j…
7b14804 
…quense#1283
@cutterbl
Provide SASS implementation of styles
34f5db6
@cutterbl
Remove duplicate style for parity with the LESS implementation from j…
26416b3 
…quense#1283
@cutterbl
Merge branch 'feature/sass' of https://github.com/cutterbl/react-big-…
10d9fb7 
…calendar into feature/sass

* 'feature/sass' of https://github.com/cutterbl/react-big-calendar:
  Remove duplicate style for parity with the LESS implementation from jquense#1283
  Provide SASS implementation of styles
@cutterbl
Updates to examples from master
2c8f343
@cutterbl
Bumping node-sass version for node 12 support
11cc0d3
@cutterbl
Merge pull request #5 from intljusticemission/master
2e5a585 
chore(deps): update overlay (jquense#1301)
@cutterbl
Provide SASS implementation of styles
19355a9
@cutterbl
Remove duplicate style for parity with the LESS implementation from j…
f6faafe 
…quense#1283
@cutterbl
Remove duplicate style for parity with the LESS implementation from j…
d99e1b1 
…quense#1283
@cutterbl
Updates to examples from master
224ca1a
@cutterbl
Bumping node-sass version for node 12 support
8264c8a
@cutterbl
Update styling to SASS (component, examples, and Storybook), and upda…
a11bdb4 
…te documentation.
@cutterbl
Merge branch 'feature/sass' of https://github.com/cutterbl/react-big-…
7e3ef44 
…calendar into feature/sass

* 'feature/sass' of https://github.com/cutterbl/react-big-calendar:
  Bumping node-sass version for node 12 support
  Updates to examples from master
  Remove duplicate style for parity with the LESS implementation from jquense#1283
  Provide SASS implementation of styles
  Remove duplicate style for parity with the LESS implementation from jquense#1283
  Provide SASS implementation of styles

# Conflicts:
#	.storybook/webpack.config.js
#	README.md
#	examples/bundle.js
#	examples/bundle.js.map
#	package.json
#	src/sass/agenda.scss
#	stories/Calendar.js
#	stories/helpers/index.js
#	yarn.lock
@cutterbl
Update yarn.lock and examples from latest master updates
a539ca6
@cutterbl
Update Examples intro.md, to include link back to README Custom Styli…
b508e0d 
…ng section
@cutterbl
Copy link
Collaborator Author

cutterbl commented May 8, 2019

@jquense You will definitely want a "Breaking Change" entry in the Changelog for this, for those using the LESS...

@cutterbl cutterbl mentioned this pull request May 8, 2019
Closed
@cutterbl
Copy link
Collaborator Author

cutterbl commented May 9, 2019

@jquense I'm reviewing the package.json, and curious about dependency usage. Seeing react and react-dom listed in both the devDependencies and the peerDependencies, with different versions. Also wondering if some of the dependencies shouldn't move into either devDependencies or peerDependencies (classnames, prop-types, etc).

@jquense
Copy link
Owner

jquense commented May 9, 2019

react is in both b/c the peerDep is signal that we need react but npm/yarn won't install it automatically (up to you to install the one version you want). It's also in devDeps, b/c to run tests and CI, etc we actually need to install react. There is probably som dep cleanup to be done but generally only things that must be installed only once belong in peer deps, so classnames, proptypes are better as direct dependencies

jquense
jquense reviewed May 9, 2019
View reviewed changes
package.json Outdated Show resolved Hide resolved
@jquense jquense changed the title Feature/sass build update feat: switch to Sass for styles May 9, 2019
@jquense jquense merged commit 884bece into jquense:master May 9, 2019
@jquense
Copy link
Owner

jquense commented May 9, 2019

thanks!

@cutterbl cutterbl deleted the feature/sassBuildUpdate branch May 9, 2019 15:34
@Coriou
Copy link

Coriou commented May 14, 2019

Thanks for the awesome work ! Since it's merged into master, can we expect a NPM publish soon ? Thanks :)

@xtursky
Copy link
Contributor

xtursky commented Jun 26, 2019

@cutterbl thanks for great work.
If I may ask, why was bootstrap-sass added to dependencies instead of devDependencies? It's used only in examples and both bootstrap and react-bootstrap are also defined there.

@jquense
Copy link
Owner

jquense commented Jun 26, 2019

maybe a bug, happy to take a PR

@xtursky xtursky mentioned this pull request Jul 3, 2019
Merged
@github-actions
Copy link

🎉 This PR is included in version 0.38.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jquense jquense jquense approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cutterbl @jquense @Coriou @xtursky