Wait until the omniorb log file is generated in clear-omninames.sh #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @mmurooka
In case something goes wrong in a surprising way in CI I think it's better to have this script timeout after e.g. 10 seconds, otherwise this gets stuck in an infinite loop and you don't get any feedback :( |
|
@gergondet Thank you for feedback. Do you think 953227e is good? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#19 does not resolve the error described there, and this PR will resolve it.
The last
tailcommand inclear-omninames.shis causing an error if the file is not found (I guess that the log file was sometimes not generated within 1sec due to the limited computing resources on the CI), so it should be fixed. Sorry for the simple mistake 😓, but I still think the previous PR is not too bad (no need to revert).With this PR patch,
clear-omninames.shwill never return in the unlikely event that the omniorb service does not create a log file. Please let me know if you have any problems with this behavior.