Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up help screen, get rid of util.py #1027

Merged
merged 9 commits into from
Aug 22, 2020

Conversation

wren
Copy link
Member

@wren wren commented Aug 16, 2020

Fixes #737 Gets rid of util.py! 🎉

This mostly just moves around code with the intent to group functions into easier-to-work-with files.

There should be no change in functionality, but will make it easier to add new features and find bugs.

There are still a few things that I would like to move, but I'll make separate issues for those later as needed.

Checklist

  • I have read the contributing doc.
  • I have included a link to the relevant issue number.
  • I have tested this code locally.
  • I have checked to ensure there aren't other open pull requests
    for the same issue.
  • I have written new tests for these changes, as needed.
  • All tests pass.

@wren
Copy link
Member Author

wren commented Aug 16, 2020

Welp, this breaks on Windows for some reason.

wren and others added 2 commits August 17, 2020 17:38
I accidentally flipped the conditional, so this fixes it.

Co-authored-by: Micah Jerome Ellison <micah.jerome.ellison@gmail.com>
@wren wren changed the title Finish refactoring of files Clean up help screen, get rid of util.py Aug 22, 2020
@micahellison micahellison added the enhancement New feature or request label Aug 22, 2020
@micahellison micahellison merged commit 631e08a into jrnl-org:develop Aug 22, 2020
@micahellison micahellison mentioned this pull request Aug 22, 2020
8 tasks
wren added a commit that referenced this pull request Oct 17, 2020
* More refactoring of cli.py

break up code from cli.py (now in jrnl.py) up into smaller functions
get rid of export mode
move --encrypt and --decrypt to commands.py
clean up the help screen even more
update flag name for import

* reorganize code, move around lots of functions

* clean up import statements

* move run function out of cli and into jrnl

* rename confusingly named function

* move editor function into editor file

* rename parse_args.py to args.py to make room for more args functions

* Fix error in test suite for windows

I accidentally flipped the conditional, so this fixes it.

Co-authored-by: Micah Jerome Ellison <micah.jerome.ellison@gmail.com>

* Update app description on help screen

Co-authored-by: Micah Jerome Ellison <micah.jerome.ellison@gmail.com>
@wren wren deleted the arg-parsing-redo2-866 branch October 18, 2020 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pull functionality out of util.py
2 participants