-
-
Notifications
You must be signed in to change notification settings - Fork 524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation updates #1032
Merged
Merged
Documentation updates #1032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wren
reviewed
Aug 29, 2020
Clean up encryption docs Clean up security docs Delete export.md Make new formats.md and add to sidebar. Also add all of the built-in formats, and examples for each. Update mkdocs config for new files
d69ab33
to
8c2de0e
Compare
wren
reviewed
Oct 18, 2020
wren
reviewed
Oct 18, 2020
wren
reviewed
Oct 18, 2020
wren
reviewed
Oct 18, 2020
wren
reviewed
Oct 18, 2020
wren
requested changes
Oct 18, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking fantastic. Just a few minor nitpicks, and I think we're good to go.
Co-authored-by: Jonathan Wren <jonathan@nowandwren.com>
Co-authored-by: Jonathan Wren <jonathan@nowandwren.com>
- Remove import/export page, fold it into formats - Rename security to privacy-and-security.md to avoid conflation w/ github security issues - Various small cleanup and edits from PR review
wren
approved these changes
Oct 24, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤠
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals for this pr:
pycrypto
is required #980, ongoing changes to overview.md #981, updated README.md #982jrnl --help
now that Clean up help screen, get rid of util.py #1027 is mergedChecklist
for the same issue.