Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation updates #1032

Merged
merged 12 commits into from
Oct 24, 2020
Merged

Documentation updates #1032

merged 12 commits into from
Oct 24, 2020

Conversation

micahellison
Copy link
Member

@micahellison micahellison commented Aug 22, 2020

Goals for this pr:

Checklist

  • I have read the contributing doc.
  • I have included a link to the relevant issue number.
  • I have tested this code locally.
  • I have checked to ensure there aren't other open pull requests
    for the same issue.
  • I have written new tests for these changes, as needed.
  • All tests pass.

docs/overview.md Outdated Show resolved Hide resolved
wren and others added 5 commits August 29, 2020 19:46
Clean up encryption docs
Clean up security docs
Delete export.md
Make new formats.md and add to sidebar. Also add all of the built-in
formats, and examples for each.
Update mkdocs config for new files
@micahellison micahellison changed the title Documentation updates [WIP] Documentation updates Oct 10, 2020
@micahellison micahellison marked this pull request as ready for review October 10, 2020 22:42
@micahellison micahellison requested a review from wren October 10, 2020 22:46
@wren wren force-pushed the develop branch 4 times, most recently from d69ab33 to 8c2de0e Compare October 18, 2020 02:04
docs/import-and-export.md Outdated Show resolved Hide resolved
docs/security.md Outdated Show resolved Hide resolved
docs/encryption.md Outdated Show resolved Hide resolved
docs/recipes.md Outdated Show resolved Hide resolved
mkdocs.yml Outdated Show resolved Hide resolved
Copy link
Member

@wren wren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking fantastic. Just a few minor nitpicks, and I think we're good to go.

micahellison and others added 3 commits October 24, 2020 11:13
Co-authored-by: Jonathan Wren <jonathan@nowandwren.com>
Co-authored-by: Jonathan Wren <jonathan@nowandwren.com>
- Remove import/export page, fold it into formats
- Rename security to privacy-and-security.md to avoid conflation w/ github security issues
- Various small cleanup and edits from PR review
@micahellison micahellison added the documentation Improvements or additions to documentation label Oct 24, 2020
Copy link
Member

@wren wren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤠

@wren wren merged commit 5b029e6 into jrnl-org:develop Oct 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants