Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace make with python alternative (poe) #1503

Merged
merged 3 commits into from
Jun 18, 2022

Conversation

wren
Copy link
Member

@wren wren commented Jun 11, 2022

This is the start of work on #1361, but does not completely fix it.

This PR:

  • Gets rid of Makefile, and the dependency on make
  • Adds Poe the Poet (poe plays nice with both poetry and tox, and is easy to setup)
  • Adds tasks previously from Makefile into pyproject.toml (in new format for poe)
  • Updates documentation to reference poe instead of make

The reason to do this is to reduce outside dependencies (poe only needs Python), and is more inclusive for Windows devs (since they previously had to install make separately, and usually with some trouble).

Checklist

  • I have read the contributing doc.
  • I have included a link to the relevant issue number.
  • I have checked to ensure there aren't other open pull requests
    for the same issue.
  • I have written new tests for these changes, as needed.

wren added 2 commits June 11, 2022 15:55
This moves the tasks that were previously in Makefile, into
pyproject.toml (with all the other config)

This is also more inclusive of Windows developers since they only need
Python, and no longer have to install make separately.
@wren wren mentioned this pull request Jun 12, 2022
4 tasks
@micahellison micahellison added the build Issues related to the build pipeline label Jun 18, 2022
@micahellison micahellison merged commit 51ab747 into jrnl-org:develop Jun 18, 2022
@micahellison micahellison deleted the no-makefile-1361 branch June 18, 2022 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues related to the build pipeline
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants