Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Tox for testing #1504

Merged
merged 6 commits into from
Jun 18, 2022
Merged

Implement Tox for testing #1504

merged 6 commits into from
Jun 18, 2022

Conversation

wren
Copy link
Member

@wren wren commented Jun 12, 2022

Fixes #1361
Fixes #1013

Note: this requires #1503 to be merged in first.

Checklist

  • I have read the contributing doc.
  • I have included a link to the relevant issue number.
  • I have checked to ensure there aren't other open pull requests
    for the same issue.
  • I have written new tests for these changes, as needed.

wren added 5 commits June 11, 2022 15:55
This moves the tasks that were previously in Makefile, into
pyproject.toml (with all the other config)

This is also more inclusive of Windows developers since they only need
Python, and no longer have to install make separately.
Conflicts:
poetry.lock
pyproject.toml
@micahellison micahellison added the build Issues related to the build pipeline label Jun 18, 2022
@micahellison micahellison merged commit 7dccc46 into jrnl-org:develop Jun 18, 2022
@micahellison micahellison deleted the add-tox-1361 branch June 18, 2022 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues related to the build pipeline
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use tox Tests don't catch missing dependencies that are included in dev
2 participants