Add instructions for VS Code #542
Conversation
Added how to ignore history appending for zsh
Fixed "-on today" option inclusive date parsing
…m being used. Now editing one entry results in "[1 entry modified]"
Fixed a bug. --edit now shows [1 entry modified] not [1 entries modified]
Handle situation where a specified jounal is not found.
Unicode fixes
Added basic logging feature to understand how is configuration loaded
Add more recent Python versions including development branches and nightly build.
Update to clarify that jrnl creates .jrnl_config file under $XDG_CONFIG/jrnl/ folder (I mistakenly interpreted the original to mean the config file should be called $XDG_CONFIG/jrnl, and was super confused that jrnl did not read it).
|
Awesome, thanks! Could you rebase that against |
|
I cherry picked my change into #544. Let me know if I should close this PR. |
|
I just setting mine to run on windows machine, you can add it to your commit : To set `Visual Studo Code <https://code.visualstudio.com/>`_ as your editor on windows, edit ``.jrnl_config`` like this:
.. code-block:: javascript
"editor" : "C:\\Program Files\\Microsoft VS Code\\Code.exe -n -w"
The -n argument tells VS Code to open new session of VS Code instead of restoring the previous session, it's necessary to close this session to handing back control to jnrl.
The -w argument tells VS Code to wait for files to be written out before handing back control to jrnl. |
|
Hello! We're just getting the jrnl repo going again and are working on getting a release together. Would you be willing to rebase against the current master branch? Thanks. |
|
Yes, let me look at this this afternoon. |
|
Thanks for your patience while I got the conflicts resolved. |
|
Let me try a local checkout of my branch and see what's breaking. |
|
Hey @emceeaich, could you have a look at #611 (and the branch underneath)? I'm suggesting moving to markdown docs to make editing easier, would love to see your changes in there! |
|
Agreed. Should I cherry pick my changes into that new branch and close this PR? |
|
That would be great, yes!
…On Mon, Jul 15, 2019 at 1:53 PM, Emma Humphries < ***@***.*** > wrote:
Agreed.
Should I cherry pick my changes into that new branch and close this PR?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub (
#542?email_source=notifications&email_token=AAH7U7NNHLISUDNKX7J7O63P7TPUXA5CNFSM4FFLCJIKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZ657QI#issuecomment-511565761
) , or mute the thread (
https://github.com/notifications/unsubscribe-auth/AAH7U7KSXUUKR6O3FBZDVFLP7TPUXANCNFSM4FFLCJIA
).
|
|
No worries! |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
No description provided.