Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instructions for VS Code #544

Merged
merged 1 commit into from
Jun 26, 2018
Merged

Add instructions for VS Code #544

merged 1 commit into from
Jun 26, 2018

Conversation

emceeaich
Copy link
Contributor

Trying to rebase with your remote 2.0-rc1 branch, and my local 2.0-rc1 branch was returning multiple conflicts and I was more than a little worried about introducing error.

Since my PR was a single commit, I think cherry-picking it from my patch-1 branch into the 2.0-rc1 branch is safer.

@maebert
Copy link
Contributor

maebert commented Jun 26, 2018

Awesome, thanks!

@maebert maebert merged commit 6baf8e3 into jrnl-org:2.0-rc1 Jun 26, 2018
@emceeaich emceeaich deleted the 2.0-rc1 branch June 26, 2018 19:12

.. code-block:: javascript

"editor": "/usr/bin/code --wait",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me, the path would be /snap/bin/code, so maybe we could go for:

"editor": "code --wait",

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, already merged, stupid me!

@wren wren added the documentation Improvements or additions to documentation label Jan 10, 2020
wren pushed a commit that referenced this pull request Apr 18, 2020
@lock
Copy link

lock bot commented May 21, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot added the 🔒 Outdated label May 21, 2020
@lock lock bot locked as resolved and limited conversation to collaborators May 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation 🔒 Outdated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants