Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dayone] re-add tests #742

Merged
merged 2 commits into from
Nov 19, 2019
Merged

[Dayone] re-add tests #742

merged 2 commits into from
Nov 19, 2019

Conversation

MinchinWeb
Copy link
Contributor

c.f. commit 7cbca9f
c.f. commit 2a40182

As per #358, this re-adds just the DayOne tests.

It also adds a "@Skip" tag to be used with tests that we don't want to run. (At one point, this may have been included in behave.) It is used here because one of the tests doesn't currently pass.

Checklist

  • The code change is tested and works locally.
  • Tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?

@MinchinWeb
[Dayone] re-add tests
ea594e5 
c.f. commit 7cbca9f
c.f. commit 2a40182
This was referenced Nov 14, 2019
Closed
Closed
@MinchinWeb
[Dayone] Skip failing tests on Travis
ad5d3a7 
Travis sets the timezone to UTC, which causes many tests to fail
@wren wren added the day one Issues related to Day One (dayoneapp.com) label Nov 19, 2019
wren
wren approved these changes Nov 19, 2019
View reviewed changes
Copy link
Member

@wren wren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@wren wren merged commit 03e8723 into jrnl-org:master Nov 19, 2019
@MinchinWeb MinchinWeb deleted the dayone-tests branch November 19, 2019 15:53
MinchinWeb added a commit to MinchinWeb/jrnl that referenced this pull request Nov 28, 2019
@MinchinWeb
[Travis] include a test in not UTC
dfeb274 
see jrnl-org#742
MinchinWeb added a commit to MinchinWeb/jrnl that referenced this pull request Nov 28, 2019
@MinchinWeb
[Travis] include a test in not UTC
9e37c4b 
see jrnl-org#742
MinchinWeb added a commit to MinchinWeb/jrnl that referenced this pull request Nov 28, 2019
@MinchinWeb
[Travis] include a test in not UTC
cdad323 
see jrnl-org#742
@MinchinWeb MinchinWeb mentioned this pull request Nov 28, 2019
Merged
6 tasks
@MinchinWeb MinchinWeb mentioned this pull request Jan 5, 2020
Merged
7 tasks
wren pushed a commit that referenced this pull request Apr 18, 2020
@MinchinWeb
[Travis] add testing on Windows and Mac
70c946b 
See #739 (Python 3.8), #619 (Windows)
Appease the Travis gods
[Travis] no auto-ruby
[Travis] include a test in not UTC
see #742
[Travis] Add Python to PATH on Windows
[Travis] Windows: try Python 3.7 for cryptography wheels?
[Travis] Windows tests time out
@lock
Copy link

lock bot commented May 21, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot added the 🔒 Outdated label May 21, 2020
@lock lock bot locked as resolved and limited conversation to collaborators May 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wren wren wren approved these changes

Assignees
No one assigned
Labels
day one Issues related to Day One (dayoneapp.com) 🔒 Outdated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MinchinWeb @wren