Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add UTC support for failing DayOne tests #785

Merged
merged 3 commits into from
Feb 8, 2020
Merged

Add UTC support for failing DayOne tests #785

merged 3 commits into from
Feb 8, 2020

Conversation

MinchinWeb
Copy link
Contributor

Travis-CI (typically) runs in UTC, and UTC behaves weird compared to other timezones. This adds UTC support to the DayOne parts of the code.

Thus this re-enables the (most of) DayOne tests (all of which broke previously, because of UTC), building on #742 .

The code change is pulled from #350.

Checklist

  • The code change is tested and works locally.
  • Tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?

@MinchinWeb MinchinWeb mentioned this pull request Jan 5, 2020
Merged
7 tasks
wren
wren reviewed Jan 5, 2020
View reviewed changes
jrnl/DayOneJournal.py Outdated Show resolved Hide resolved
wren
wren requested changes Jan 10, 2020
View reviewed changes
Copy link
Member

@wren wren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline comments.

@MinchinWeb MinchinWeb requested a review from wren January 17, 2020 15:44
@MinchinWeb
[DayOne] change as per code review
5425b35 
to avoid `except: pass`
@MinchinWeb
Copy link
Contributor Author

@wren: changed as requested! This, and #786 should be good to go!

@MinchinWeb MinchinWeb mentioned this pull request Jan 28, 2020
Open
@wren wren changed the title [Dayone] UTC support Add UTC support for failing DayOne tests Feb 8, 2020
@wren wren added bug Something isn't working day one Issues related to Day One (dayoneapp.com) labels Feb 8, 2020
wren
wren approved these changes Feb 8, 2020
View reviewed changes
Copy link
Member

@wren wren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, again! And extra thanks for your patience while we were working on v2.2.

@wren wren merged commit 550347e into jrnl-org:develop Feb 8, 2020
@MinchinWeb MinchinWeb deleted the dayone-utc branch March 21, 2020 22:55
wren pushed a commit that referenced this pull request Apr 18, 2020
@MinchinWeb
Add UTC support for failing DayOne tests (#785)
66027e7 
* [Dayone] don't break if the system timezone is UTC
* [DayOne] re-enable tests that were failing on Travis
* [DayOne] change as per code review to avoid `except: pass`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wren wren wren approved these changes

Assignees
No one assigned
Labels
bug Something isn't working day one Issues related to Day One (dayoneapp.com)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MinchinWeb @wren