Refactor parse query and percent-encode sets #152
Conversation
There was a problem hiding this comment.
This doesn't appear up to date with https://whatpr.org/url/518.html, in particular the percent-encode after encoding operation or various other changes. Unfortunately maybe we lagged behind a bit on other editorial changes which would make this a bigger lift.
Do you want me to help get this up to date?
|
I would appreciate help, yes. In particular with pulling in some kind of encoding library and figuring out how to run the tests in encoding/ relevant to URLs. (It also seems like jsdom/whatwg-encoding isn't quite compliant, but maybe it's good enough for some tests...) I was also thinking that maybe url-state-machine.js and urlencoded.js could both use a shared percent-encoded.js that contains all that logic. |
|
Great. Depending on how much time you have today, getting #154 (whatwg/url#459) and #151 (whatwg/url#512) merged first would be nice. And ideally #148 (whatwg/url#505), though that still needs tests. But we can also do it independently, and deal with any merge conflicts as necessary. |
|
Covered the first two. I also lack implementer interest for that last one unfortunately. |
Follows whatwg/url#518. This generally tries to make the code correspond more explicitly to the specification in a few ways. It doesn't handle non-UTF-8 encodings yet, though. Supersedes #152.
See whatwg/url#386 and whatwg/url#518.