Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forbid <, >, and ^ in hosts #459

Merged
merged 4 commits into from
May 14, 2020
Merged

Forbid <, >, and ^ in hosts #459

merged 4 commits into from
May 14, 2020

Conversation

ZYSzys
Copy link
Contributor

@ZYSzys ZYSzys commented Dec 12, 2019

Considering <> seem to be forbidden in two browsers, we should consider making them forbidden too. The list is testable through new URL('http://</').href.

This PR add < and > to Host miscellaneous, Close #458


Preview | Diff

@annevk annevk mentioned this pull request May 7, 2020
url.bs Outdated Show resolved Hide resolved
@annevk annevk added the needs tests Moving the issue forward requires someone to write tests label May 7, 2020
Co-authored-by: Anne van Kesteren <annevk@annevk.nl>
Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks great. Hopefully @domenic is still up for writing tests. If not I might be able to get to it.

@domenic
Copy link
Member

domenic commented May 7, 2020

Sadly I'm not able to spare the creative energy for writing tests, but I can do the usual jsdom/whatwg-url testing and reviewing. In advance I will report that there is only one failure in the existing test suite, which is parsing sc://!"$&'()*+,-.;<=>^_`{|}~/ against about:blank.

@rmisev
Copy link
Member

rmisev commented May 13, 2020

Added tests: web-platform-tests/wpt#23572

Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and web platform tests pass. Be sure to update the commit message to account for ^ too when merging.

domenic added a commit to jsdom/whatwg-url that referenced this pull request May 14, 2020
@annevk annevk merged commit 302ba41 into whatwg:master May 14, 2020
@annevk annevk changed the title Forbid < and > in hosts Forbid <, >, and ^ in hosts May 14, 2020
@annevk
Copy link
Member

annevk commented May 14, 2020

Thanks everyone!

I filed https://bugs.webkit.org/show_bug.cgi?id=211901. Firefox and Chrome already have a more general bug on implementing non-special URLs properly.

domenic pushed a commit to web-platform-tests/wpt that referenced this pull request May 14, 2020
domenic added a commit to jsdom/whatwg-url that referenced this pull request May 14, 2020
yashLadha added a commit to yashLadha/node that referenced this pull request May 21, 2020
As per the recent changes in whatwg/url spec. lt and gt are also added
in the list of forbidden hostCodePoint list.

Ref: whatwg/url#459
Ref: nodejs#33315
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request May 23, 2020
As per the recent changes in whatwg/url spec. lt and gt are also added
in the list of forbidden hostCodePoint list.

PR-URL: nodejs#33328
Refs: whatwg/url#459
Refs: nodejs#33315
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
rmisev added a commit to upa-url/upa that referenced this pull request May 24, 2020
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request May 26, 2020
…only

Automatic update from web-platform-tests
URL: forbid <, >, and ^ in hosts

Follows whatwg/url#459.
--

wpt-commits: 9ffe8f26432649d02eb81add2816dd5394f57a8c
wpt-pr: 23572
xeonchen pushed a commit to xeonchen/gecko that referenced this pull request May 26, 2020
…only

Automatic update from web-platform-tests
URL: forbid <, >, and ^ in hosts

Follows whatwg/url#459.
--

wpt-commits: 9ffe8f26432649d02eb81add2816dd5394f57a8c
wpt-pr: 23572
djc added a commit to servo/rust-url that referenced this pull request Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs tests Moving the issue forward requires someone to write tests
Development

Successfully merging this pull request may close these issues.

Forbid < and > in hosts
4 participants