Rename $recursive* to $dynamic*, make it work with normal anchors / plain name fragments instead of base URI switching #930
Conversation
handrews
requested review from
awwright,
jdesrosiers,
Relequestual and
gregsdennis
|
Note for those who saw the note that I removed from the main description: I decided not to try to do overly clever things with the hyper-schema meta-schemas, and added a commit that just updates them (and the other meta-schemas) more or less as they are. I might come back to the idea (which involved both the hyper-schema meta-schema and the links schema being dynamically extended) but TBH it's pretty complicated and of questionable value. Let's focus on the essentials for now. |
There was a problem hiding this comment.
This looks good and looks like it resolved the issues it claims to resolve.
The was one section where I'm not sure I fully understand, even with the example.
Given the changes are clear to me apart from that small section, once explained, it may need a small tweak language wise.
|
Also, I'll leave this open for the full 14-day period for major changes, but once approved I'll work on #849 and #857 on the assumption that this or something very much like it will get merged. That work (about schema loading) needed to account for whether the old runtime base URI switching was present, which made the loading+runtime process substantially more complex. |
Preliminary work for revamping these keywords.
Instead of using a boolean (which never really fit with how the similarly named "$anchor" worked, and meant only one dynamic resolution was possible at a time) and messing with base URIs and re-resolving URI-references (a topic that creates plenty of confusion even on its own), use a fragment name the same as "$anchor" and make "$dynamicRef" work by just looking for the outermost resource with a matching "$dynamicAnchor" fragment name. This stil requires that the initial "$dynamicRef" target URI be a valid URI, with a fragment created by "$dynamicAnchor", in order to produce the dynamic behavior. This ensures that it is always clear which schemas are dynamic extension points and which are not.
This updates for the change of $recursiveRef (with a boolean) to $dynamicAnchor (with a plain name fragment), and provides a more detailed example of how the dynamic scope is used.
Replace $recursiveAnchor: true with $dynamicAnchor: "meta" and update $recursiveRef to $dynamicRef accordingly.
/theses/these/
|
I may have fix / fixed typo... If only I had been consistent in that... =] |
|
@karenetheridge can you review this again please? =] |
|
@Relequestual looks great. I had to stare at |
Closes #909 (improve/simplify/rename
$recursive*)Closes #868 (Let's not require runtime base URI tracking)
Also addresses 2/3 or #809 (overly long section names) but the other 1/3 is not in this part of the spec so I'll close that separately.
Instead of using a boolean (which never really fit with how the similarly named "$anchor" worked, and meant only one dynamic resolution was possible at a time) and messing with base URIs and re-resolving URI-references (a topic that creates plenty of confusion even on its own), use a fragment name the same as "$anchor" and make "$dynamicRef" work by just looking for the outermost resource with a matching "$dynamicAnchor" fragment name.
This stil requires that the initial "$dynamicRef" target URI be a valid URI, with a fragment created by "$dynamicAnchor", in order to produce the dynamic behavior. This ensures that it is always clear which schemas are dynamic extension points and which are not.