-
-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename $recursive* to $dynamic*, make it work with normal anchors / plain name fragments instead of base URI switching #930
Merged
Commits on May 31, 2020
-
Rename "$recursive*" to "$dynamic*"
Preliminary work for revamping these keywords.
Configuration menu - View commit details
-
Copy full SHA for c86157c - Browse repository at this point
Copy the full SHA c86157cView commit details -
$dynamicAnchor creates fragment, no base URI stuff
Instead of using a boolean (which never really fit with how the similarly named "$anchor" worked, and meant only one dynamic resolution was possible at a time) and messing with base URIs and re-resolving URI-references (a topic that creates plenty of confusion even on its own), use a fragment name the same as "$anchor" and make "$dynamicRef" work by just looking for the outermost resource with a matching "$dynamicAnchor" fragment name. This stil requires that the initial "$dynamicRef" target URI be a valid URI, with a fragment created by "$dynamicAnchor", in order to produce the dynamic behavior. This ensures that it is always clear which schemas are dynamic extension points and which are not.
Configuration menu - View commit details
-
Copy full SHA for 940586a - Browse repository at this point
Copy the full SHA 940586aView commit details -
Update recursive schema example for $dynamicAnchor
This updates for the change of $recursiveRef (with a boolean) to $dynamicAnchor (with a plain name fragment), and provides a more detailed example of how the dynamic scope is used.
Configuration menu - View commit details
-
Copy full SHA for d8d7ec0 - Browse repository at this point
Copy the full SHA d8d7ec0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1875b36 - Browse repository at this point
Copy the full SHA 1875b36View commit details -
Update meta-schemas for $dynamic*
Replace $recursiveAnchor: true with $dynamicAnchor: "meta" and update $recursiveRef to $dynamicRef accordingly.
Configuration menu - View commit details
-
Copy full SHA for 46ae014 - Browse repository at this point
Copy the full SHA 46ae014View commit details -
Configuration menu - View commit details
-
Copy full SHA for 30f97c8 - Browse repository at this point
Copy the full SHA 30f97c8View commit details
Commits on Jun 25, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 219cbc3 - Browse repository at this point
Copy the full SHA 219cbc3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2dcb418 - Browse repository at this point
Copy the full SHA 2dcb418View commit details
Commits on Jul 3, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 8e5f8e1 - Browse repository at this point
Copy the full SHA 8e5f8e1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9821063 - Browse repository at this point
Copy the full SHA 9821063View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.