jsx-a11y/control-has-associated-label throws an error on table elements

[elianarlivingston]

Hello! I'm experiencing an issue with lint on the 'td' or 'th' elements. Is it correct that this error is being generated? Thank you in advance!

[christopher-william]

I have the same problem, with this version 6.8

[AlanGreene]

I've just run into the same issue updating to 6.8.0.

From a quick review of the changelog and recent history it looks like an intentional change, or at the very least a side effect of an intentional change: #919

In my case it's triggered by an empty <td> used in a skeleton loading state.

[ZeeshanTamboli]

Same issue for us in Material UI - mui/material-ui#39752.

[frantic1048]

We are sticking to the older 6.7.1 version to avoid this issue.

Versions 6.8 and the recent 6.9 still encounter this issue.

[ljharb]

@elianarlivingston @christopher-william @frantic1048 can you provide some code that reproduces the issue?

[frantic1048]

Here's reproduction repo: https://github.com/frantic1048/eslint-plugin-jsx-a11y-issue-959

• ESLint output: https://github.com/frantic1048/eslint-plugin-jsx-a11y-issue-959/actions/runs/9739279809/job/26874221357
• Code: https://github.com/frantic1048/eslint-plugin-jsx-a11y-issue-959/blob/master/src/App.tsx

It appears that this issue is related to the case where a <th> element has only one self-closing child tag.

[ZeeshanTamboli]

Shouldn't th and td be added to ignoreElements in the rule here since they are non-interactive? Would that fix the issue?

[ljharb]

I suppose that'd be one solution.

[ZeeshanTamboli]

I suppose that'd be one solution.

@ljharb I can add that. But will eslint-config-airbnb be released? I am hesitant because I see it was released two years ago. We extend eslint-config-airbnb which has this a11y rule.

[ljharb]

@ZeeshanTamboli the rule is part of this plugin, not the airbnb config, so you don't need the airbnb config to do anything to be able to use new releases of this plugin. that said, yes, the airbnb config will be released for eslint 9 support once everything it depends on has it.

[ZeeshanTamboli]

@ljharb I understand the rule is part of this plugin. What I meant is that we extend the Airbnb config (extends: ['eslint-config-airbnb']), which uses the rule defined here. If I update the ignoreElements list there, wouldn’t eslint-config-airbnb need a new release?

[ljharb]

You can override that rule config however you like, without a new release.

[ZeeshanTamboli]

You can override that rule config however you like, without a new release.

Yes, but that would be a workaround just to wait for the actual fix to happen. Overriding to just add the two elements in the list.

[ljharb]

Yep, that's right

[ZeeshanTamboli]

Yep, that's right

:P So can't we release eslint-config-airbnb minor patch with the fix?

[ljharb]

This wouldn't be the repo to ask on, and this is an issue about this plugin, not about the airbnb config.

[ZeeshanTamboli]

This wouldn't be the repo to ask on, and this is an issue about this plugin, not about the airbnb config.

Agree. Created airbnb/javascript#3069.