[core] Update eslint-plugin-jsx-a11y
#44701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZeeshanTamboli
changed the title
eslint plugin jsx a11yeslint-plugin-jsx-a11y
Netlify deploy previewhttps://deploy-preview-44701--material-ui.netlify.app/ Bundle size report |
ZeeshanTamboli
changed the title
eslint-plugin-jsx-a11yeslint-plugin-jsx-a11y
|
@mui/code-infra Can this be reviewed? |
JCQuintas
approved these changes
Dec 16, 2024
Co-authored-by: Jose C Quintas Jr <juniorquintas@gmail.com> Signed-off-by: Zeeshan Tamboli <zeeshan.tamboli@gmail.com>
Janpot
approved these changes
Dec 16, 2024
| @@ -158,6 +164,16 @@ module.exports = /** @type {Config} */ ({ | |||
| ], | |||
| // We are a library, we need to support it too | |||
| 'jsx-a11y/no-autofocus': 'off', | |||
| // Remove when issues are fixed | |||
| // https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/issues/959 | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #39752. The CI linting test fails for
tdandthelements.I was waiting for this issue to be resolved, but since we use airbnb base config, the Airbnb config would need updating. I’ve opened a new issue for that: airbnb/javascript#3069. But it won't be updated sooner and it is suggested to override configs.
To unblock the
eslint-plugin-jsx-a11yupdate, this PR overrides the rule by addingtdandthto theignoreElementslist.