[Fix] fix unstable plugin reference with flat configs #1038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous use of spread meant that
```ts
import jsxA11y from 'eslint-plugin-jsx-a11y';
jsxA11y !== jsxA11y.flatConfigs.recommended.plugins['jsx-a11y']
```
This is a problem because if someone does something like this
```js
import jsxA11y from 'eslint-plugin-jsx-a11y';
export default [
{ plugins: { 'jsx-a11y': jsxA11y } },
jsxA11y.flatConfigs.recommended,
];
```
then ESLint will crash with the error `Config "jsx-a11y/recommended": Key "plugins": Cannot redefine plugin "jsx-a11y".`
This PR fixes that by using `Object.assign` to mutate the `jsxA11y` object and maintain referential equality.
|
Can we add a test that covers this? |
ljharb
approved these changes
Nov 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous use of spread meant that
This is a problem because if someone does something like this
then ESLint will crash with the error
Config "jsx-a11y/recommended": Key "plugins": Cannot redefine plugin "jsx-a11y".This PR fixes that by using
Object.assignto mutate thejsxA11yobject and maintain referential equality.