Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] fix unstable plugin reference with flat configs #1038

Merged
merged 1 commit into from
Nov 17, 2024

Commits on Nov 15, 2024

  1. [Fix] ensure stable plugin reference with flat configs

    The previous use of spread meant that
    ```ts
    import jsxA11y from 'eslint-plugin-jsx-a11y';
    
    jsxA11y !== jsxA11y.flatConfigs.recommended.plugins['jsx-a11y']
    ```
    
    This is a problem because if someone does something like this
    ```js
    import jsxA11y from 'eslint-plugin-jsx-a11y';
    
    export default [
      { plugins: { 'jsx-a11y': jsxA11y } },
      jsxA11y.flatConfigs.recommended,
    ];
    ```
    then ESLint will crash with the error `Config "jsx-a11y/recommended": Key "plugins": Cannot redefine plugin "jsx-a11y".`
    
    This PR fixes that by using `Object.assign` to mutate the `jsxA11y` object and maintain referential equality.
    bradzacher authored and ljharb committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    53ca775 View commit details
    Browse the repository at this point in the history