Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: destructure of adapter config error #11

Merged
merged 2 commits into from
Feb 9, 2021
Merged

Conversation

jthegedus
Copy link
Owner

@jthegedus jthegedus commented Feb 9, 2021

Summary

Investigating #6 uncovered two errors:

  1. adapter logging was no longer advising the user how to setup their server
  2. adapter configuration did not support an empty config as the object param did not have a default set so tried to destructure undefined

Fixes were included:

  1. in fix: elevate logs to .warn & check CFs for @sveltejs/kit dep #9
  2. is being fixed here

Fixes: #6

Other Information

This PR also fixes an issue with the pre-commit hook introduced in #10 It now adds to formatted code to the current commit.

@jthegedus
Copy link
Owner Author

Integration tests would have revealed issue 2., consider adding these later

@jthegedus jthegedus merged commit 6ece557 into main Feb 9, 2021
@jthegedus jthegedus deleted the fix/default-config branch February 9, 2021 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: issues deploying to Cloud Functions
1 participant