fix: elevate logs to .warn & check CFs for @sveltejs/kit dep
#9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jthegedus
changed the title
@sveltejs/kit dep@sveltejs/kit dep
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
elevate logging level:
The core of this adapter is to output helpful logs to the user when their configuration does not meet the requirements of either a Cloud Function or Cloud Run deployment. Updates to SvelteKit in
1.0.0-next.27put thebuilder.log.infoor.minorlogging functions behind the--verboseflag. Given console output is the core feature here, we will elevate this to.warnlog level when noting a validation issue with the user's config.Resolves part of bug: issues deploying to Cloud Functions #6
add a check and subsequent log for the required Cloud Function dep
@sveltejs/kitremove GitHub Releases publish workflow in favour of
standard-versionand manual release vianpm run releaseformat the code with
npx xo --fix