Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reading 'log' error #157

Merged
merged 2 commits into from
May 14, 2022
Merged

fix: reading 'log' error #157

merged 2 commits into from
May 14, 2022

Conversation

co3k
Copy link
Contributor

@co3k co3k commented Feb 16, 2022

Summary

Added some changes to follow latest Kit adapter API changes (sveltejs/kit#2931).
This pull request fixes #156 problem and it might be fix a part of #153 issues.

fixes #156
refs #153

@co3k co3k changed the title fix reading 'log' error fix: reading 'log' error Feb 17, 2022
@rudimusmaximus
Copy link

@Nushio can you confirm that this is still an issue even after #159 merged?

@Nushio
Copy link
Collaborator

Nushio commented May 13, 2022

This PR does not need to be merged. It's fixed after #159.
I'm preparing a PR with a few lints and documentation changes to highlight the 0.14.0 release.

@rudimusmaximus
Copy link

@Nushio Thank you! I thought 159 was already in and was blocked by this. Anyway, I'm looking forward to getting up to speed and helping out whenever. I want to use svelteKit on firebase :) Appreciate the community adapter.

@Nushio Nushio merged commit f855bfb into jthegedus:main May 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Cannot read properties of undefined (reading 'log')
3 participants