-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support for SvelteKit Next 303 #159
Conversation
Co-authored-by Kousuke Ebihara <kousuke@co3k.org> Co-authored by-Niels van der Molen <nielsvandermolen@gmail.com>
@nielsvandermolen please see the Lint PR failure |
Done |
Any updates regarding merging this? |
Maybe time to fork this project since @jthegedus seems to be permanently AFK. Hope he's ok |
Is there anybody who would be willing, and has the time to maintain a fork? I'd do it but then I've just done https://github.com/evdama/is-it-check which pretty much consumed my FLOSS time budget for this quarter so... |
I could help in maintaining the fork as I am needing this library for a project we just started at work and I wasn't aware of all the build issues until just now since local emulation was working splendidly. It seems to me just having a fork of the existing repo with the 2 PRs open on this repo merged in with verification would be sufficient to begin with? |
We're using svelte-adapter-firebase at work and am interested in helping co-maintain. |
Not sure what 'best practice' is in these situations, but maybe the fork could make @jthegedus a collaborator, so if he comes back, we don't have an awkward situation where 2 forks are maintained in parallel? |
You say "both" PRs, which other PRs are valid that I need to merge to unblock people? |
Sorry all, my time is not my own right now. I was genuine in my prior responses, I was just wrong. @Nushio I have invited you to collaborate on this repo to help as you seem to be more up to date with the state of things. I am part of the Firebase Alpha program and there are a few new changes coming soon which may affect how this tool can integrate with peoples existing projects, so I will wait for those to release before reconsidering any of the more complex feature support like functions per route. I have been considering the utility of a sveltekit-adapter-community GitHub org which might mitigate situations like this, however, I do encourage people to fork in these situations, use privately, and if there ends up being multiple solutions down the road, so be it. |
Invite @nielsvandermolen as well? 🚀 🚀 🚀 |
Sorry, to be more specific, I tested both PRs, naabu's and co3k's. I am flattered and really appreciate being a co-maintainer! I've been following your work, jthegus, throughout the github issues and commits on everything related to svelte kit. I'm excited for whatever Firebase might come up with in the near future. I/O, maybe? Blink twice if yes. |
Summary
Update Adapter to support the latest version (next@303) of SvelteKit.
Fixes: #153
No support for fancy features like route splitting.
Tested deployment on a live site with Firebase
Other Information
Took some code from the other PR #157 so the author deserves credit.
Implementation details