Show layer icon near mouse pointer (win-tray) #1031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eugenesvk
force-pushed
the
gui_win_tooltip_layer
branch
3 times, most recently
from
eebdd6d
to
c2a87e0
Compare
4 tasks
jtroo
reviewed
May 19, 2024
jtroo
reviewed
May 19, 2024
1 task
add gui struct Icn
to fix nwg bug when loading ICONs as images, which we need for menu/tooltip icons
use a separate get_icon_from_file to read from file, then convert image to various formats for the icon/tooltip/tray
to be read from user config
both gui-driven and kanata-driven
eugenesvk
force-pushed
the
gui_win_tooltip_layer
branch
from
e2066fe
to
0234f49
Compare
jtroo
approved these changes
May 19, 2024
Co-authored-by: jtroo <j.andreitabs@gmail.com>
Co-authored-by: jtroo <j.andreitabs@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes. Use imperative present tense.
Adds an option to show layer icons not only in the tray area, but also near a more in-focus mouse pointer, and also add system tray notifications on config reloads (though this currently doesn't show fails for
rldactions, only for reloads via gui)(also added build options for the gui exe)
Checklist
Partially addresses #741 and #1025
with a system notification