Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log errors via Windows notification system #1049

Merged
merged 21 commits into from
May 25, 2024

Conversation

eugenesvk
Copy link
Contributor

Describe your changes. Use imperative present tense.

Add an extra way for the Windows logger to notify on errors: use the OS notification system to show whatever fits
Configurable, on by default
Other log levels do not use OS notification to avoid spamming

(this is based on #1031 to make it easier to add, so will rebase on whatever that one ends up being after review)

Checklist

  • Add documentation to docs/config.adoc
    • Yes or N/A
  • Add example and basic docs to cfg_samples/kanata.kbd
    • Yes or N/A
  • Update error messages
    • Yes or N/A
  • Added tests, or did manual testing
    • Yes

@eugenesvk eugenesvk force-pushed the gui_win_log_to_OS_noti branch 2 times, most recently from a28d34b to 3f4a007 Compare May 20, 2024 08:41
@eugenesvk eugenesvk force-pushed the gui_win_log_to_OS_noti branch from 3f4a007 to 7a9d0ac Compare May 20, 2024 18:59
src/gui/win.rs Outdated Show resolved Hide resolved
src/gui/win.rs Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
@jtroo jtroo merged commit 96d6d08 into jtroo:main May 25, 2024
4 checks passed
@eugenesvk eugenesvk deleted the gui_win_log_to_OS_noti branch May 25, 2024 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants