-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log errors via Windows notification system #1049
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eugenesvk
force-pushed
the
gui_win_log_to_OS_noti
branch
2 times, most recently
from
May 20, 2024 08:41
a28d34b
to
3f4a007
Compare
to allow importing functions from the main GUI
eugenesvk
force-pushed
the
gui_win_log_to_OS_noti
branch
from
May 20, 2024 18:59
3f4a007
to
7a9d0ac
Compare
jtroo
reviewed
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes. Use imperative present tense.
Add an extra way for the Windows logger to notify on errors: use the OS notification system to show whatever fits
Configurable, on by default
Other log levels do not use OS notification to avoid spamming
(this is based on #1031 to make it easier to add, so will rebase on whatever that one ends up being after review)
Checklist