Define a minimum gettext version rather than an exact one #32
Conversation
|
Great, thank you! Can you please add the nice description/explanation to the message body of your git commit, so that we have it in the repo and not just on GitHub? Also: under which name/email would you like to get added to the AUTHORS file? |
This PR prevents an error caused by the `Makefile.in.in` being for the exact gettext version specified in `configure.ac`, but the autoconf macros used being from whatever the latest version available on the system is. Example: ``` Making all in po *** error: gettext infrastructure mismatch: using a Makefile.in.in from gettext version 0.19 but the autoconf macros are from gettext version 0.20 make[1]: *** [stamp-po] Error 1 make: *** [all-recursive] Error 1 ``` Leaving `AM_GNU_GETTEXT_VERSION` to act as a fall back but it will not be used if a version of `autopoint` that supports `AM_GNU_GETTEXT_REQUIRE_VERSION` is present. `0.19` had to be bumped to at least `0.19.6` as that is where `AM_GNU_GETTEXT_REQUIRE_VERSION` was first introduced.
|
@jubalh just my GH username and no email. |
|
Alright will do so. Thanks for the PR. |
|
@jubalh any chance you can cut a new release soon? This change will allow the Homebrew formula to be updated with the |
|
I'm not sure I'll have time. Please just patch your package. |
|
@jubalh any chance of a |
|
Sorry I totally forgot your last request. Did you patch the package in the meantime? Or is there a problem just doing that? |
|
Yes it has been patched for a while now. Would just be nice to get a release going with the changes built in. |
This PR prevents an error caused by the
Makefile.in.inbeing for the exact gettext version specified inconfigure.ac, but the autoconf macros used being from whatever the latest version available on the system is.Example:
Leaving
AM_GNU_GETTEXT_VERSIONto act as a fall back but it will not be used if a version ofautopointthat supportsAM_GNU_GETTEXT_REQUIRE_VERSIONis present.0.19had to be bumped to at least0.19.6as that is whereAM_GNU_GETTEXT_REQUIRE_VERSIONwas first introduced.