Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Japanese translation for #39 #40

Merged
merged 4 commits into from
Sep 1, 2020
Merged

Fix Japanese translation for #39 #40

merged 4 commits into from
Sep 1, 2020

Conversation

cmplstofB
Copy link
Contributor

I have fixed Japanese translation file for issue #39 .
Sorry for troubling you.

@jubalh jubalh merged commit 676ed93 into jubalh:master Sep 1, 2020
@jubalh
Copy link
Owner

jubalh commented Sep 1, 2020

Cool, thanks for fixing this! :)

@cmplstofB cmplstofB deleted the feature/japanese-translation branch September 1, 2020 14:25
@jubalh jubalh mentioned this pull request Sep 1, 2020
Closed
@cmplstofB
Copy link
Contributor Author

I want you to make sure I have really fixed that issue, could you please?
I'm still worried about it...

@BachoSeven
Copy link

It is fixed @cmplstofB, I just closed #39 as well. Thanks again!

jubalh added a commit that referenced this pull request Nov 20, 2020
@jubalh
Release 2.1.0
0efc861 
* Use actual terminal background color (instead of black) as background color (pr #31)
* Define minimum gettext version instead of exact one (pr #32)
* Require gettext 0.20
* Add Japanese translation (pr #40)
* Minor code change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cmplstofB @jubalh @BachoSeven