Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dutch translation #153

Merged
merged 4 commits into from
Jun 22, 2017
Merged

Dutch translation #153

merged 4 commits into from
Jun 22, 2017

Conversation

RoySchutte
Copy link
Contributor

The current Dutch (Belgium) translations are somewhat bad (grammatically). Please use these (at least for values-nl-rNL).

The current Dutch (Belgium) translations are somewhat bad (grammatically). Please use these (at least for values-nl-rNL).
Fixed small contextual error.
@julian-klode
Copy link
Owner

@RoySchutte The nl-rBE translation was done by @Ox0000 - I'd like to get some input. I am curious if I should replace nl-rBE with just nl or not, I don't really know the differences between "standard" and Belgian Dutch (this thing is mostly technical, I'd be surprised if there are any important ones).

@julian-klode julian-klode changed the title Create string.xml Dutch translation Jun 19, 2017
Copy link
Owner

@julian-klode julian-klode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI failed. Untranslatable strings have been translated.

/home/travis/build/julian-klode/dns66/app/src/main/res/values-nl/string.xml:2: Error: Non-translatable resources should only be defined in the base values/ folder [ExtraTranslation]
DNS66
~~~~~~~~~~~~~~~~~~~~
/home/travis/build/julian-klode/dns66/app/src/main/res/values-nl/string.xml:15: Error: Non-translatable resources should only be defined in the base values/ folder [ExtraTranslation]
© 2016 Julian Andres Klode
~~~~~~~~~~~~~~~~~~~~
/home/travis/build/julian-klode/dns66/app/src/main/res/values-nl/string.xml:46: Error: Non-translatable resources should only be defined in the base values/ folder [ExtraTranslation]
https://github.com/julian-klode/dns66

@RoySchutte
Copy link
Contributor Author

Hi @julian-klode,

I should have explained better. NL-NL (Dutch) and NL-BE (Belgian) are grammatically nearly identical (a few exceptions). We speak the 'same' language. It's more like a different accent, like English and American.

The grammatical errors I'm seeing apply to both languages. However, I see that @Ox0000 also used a few words that are uncommon in Dutch, and more common in Belgian. As I am Dutch, I changed those words too.

What I tried to say in the original pull comment is:

  1. Please (at least) use my translations for nl-rNL.
  2. Optional: Replace the Belgian file with mine as well, to get rid of the grammatical errors. Ox0000 (or any other contributer) can change the common Dutch words back to Belgian if he/she wishes.

@RoySchutte
Copy link
Contributor Author

Made small changes to make descriptions clearer for users.

@julian-klode
Copy link
Owner

The review still stands. If you want this merged, please fix the build failure.

@julian-klode julian-klode merged commit 718c512 into julian-klode:master Jun 22, 2017
@julian-klode julian-klode added this to the 0.5.4 milestone Jun 22, 2017
julian-klode added a commit that referenced this pull request Jun 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants