Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Model and UniversalFallback #1245

Merged
merged 9 commits into from
Mar 11, 2021
Merged

Conversation

blegat
Copy link
Member

@blegat blegat commented Feb 19, 2021

Closes #1234

@blegat blegat force-pushed the bl/vector_of_constraints branch 4 times, most recently from bf9e19e to e69921f Compare February 23, 2021 20:44
@blegat blegat mentioned this pull request Mar 3, 2021
@blegat blegat force-pushed the bl/vector_of_constraints branch from 7875c15 to 7563db9 Compare March 4, 2021 21:00
@blegat blegat marked this pull request as ready for review March 5, 2021 10:59
@blegat blegat changed the title [WIP] Refactor Model and UniversalFallback Refactor Model and UniversalFallback Mar 5, 2021
@blegat blegat force-pushed the bl/vector_of_constraints branch 3 times, most recently from 27e2450 to bb970bf Compare March 5, 2021 12:29
@blegat blegat force-pushed the bl/vector_of_constraints branch 2 times, most recently from ddf9fe7 to 3c29f6b Compare March 8, 2021 22:05
@odow odow force-pushed the bl/vector_of_constraints branch from 3c29f6b to 8afdfe2 Compare March 10, 2021 21:31
@odow
Copy link
Member

odow commented Mar 10, 2021

So this is actually slower than before, when run on the JuMP examples (The stress_precompile function here: jump-dev/JuMP.jl#2484).

Before:

 78.339035 seconds (204.57 M allocations: 11.833 GiB, 5.22% gc time, 6.89% compilation time)

After:

88.580525 seconds (220.25 M allocations: 12.709 GiB, 5.61% gc time, 14.41% compilation time)

However, it is more readable. I'd be in favor of merging so we can make other changes in future PRs. There are likely some performance things we can tweak.

@blegat blegat merged commit e0f8b05 into master Mar 11, 2021
@blegat blegat deleted the bl/vector_of_constraints branch March 11, 2021 08:20
@blegat
Copy link
Member Author

blegat commented Mar 11, 2021

Thanks for doing a benchmark. I think there is an issue with Fix1 and CleverDict as we have Fix1{DataType, ...} which does not play well with inference.

@blegat blegat mentioned this pull request Mar 11, 2021
@blegat blegat added this to the v0.9.21 milestone May 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Refactor UniversalFallback and Model with VectorOfConstraints
2 participants