-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Model and UniversalFallback #1245
Conversation
bf9e19e
to
e69921f
Compare
7875c15
to
7563db9
Compare
27e2450
to
bb970bf
Compare
ddf9fe7
to
3c29f6b
Compare
3c29f6b
to
8afdfe2
Compare
So this is actually slower than before, when run on the JuMP examples (The Before: 78.339035 seconds (204.57 M allocations: 11.833 GiB, 5.22% gc time, 6.89% compilation time) After: 88.580525 seconds (220.25 M allocations: 12.709 GiB, 5.61% gc time, 14.41% compilation time) However, it is more readable. I'd be in favor of merging so we can make other changes in future PRs. There are likely some performance things we can tweak. |
Thanks for doing a benchmark. I think there is an issue with |
Closes #1234