Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix return types in model.jl #1282

Closed
wants to merge 3 commits into from
Closed

Fix return types in model.jl #1282

wants to merge 3 commits into from

Conversation

odow
Copy link
Member

@odow odow commented Mar 10, 2021

Some of these were causing unexpected returns from function calls.

Here was an example:

julia> c = MOI.add_constraint(model, MOI.VectorOfVariables(x), MOI.Nonnegatives(2))
MathOptInterface.ConstraintIndex{MathOptInterface.VectorOfVariables,MathOptInterface.Nonnegatives}(2)

julia> MOI.delete(model, c)
Dict{MathOptInterface.ConstraintIndex,String} with 0 entries  # <-- What is this?

@odow odow added the Submodule: Utilities About the Utilities submodule label Mar 10, 2021
@blegat
Copy link
Member

blegat commented Mar 10, 2021

I'd rather merge #1245 first or it will create a lot of conflicts

@odow
Copy link
Member Author

odow commented Mar 10, 2021

Is #1245 ready to review?

I needed this for #1281

@blegat
Copy link
Member

blegat commented Mar 10, 2021

Is #1245 ready to review?

Yes :)

@odow
Copy link
Member Author

odow commented Mar 11, 2021

Closing because this was implemented in #1245

@odow odow closed this Mar 11, 2021
@odow odow deleted the od/model_return branch March 11, 2021 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Submodule: Utilities About the Utilities submodule
Development

Successfully merging this pull request may close these issues.

2 participants