Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid NullPointerException when deserializing TestIdentifier #3837

Closed
wants to merge 1 commit into from

Conversation

dmlloyd
Copy link
Contributor

@dmlloyd dmlloyd commented May 30, 2024

Overview

An NPE was thrown when (de)serializing TestIdentifiers without a parent.

Fixes #3819.

This is a backport of #3820 to the 5.10.x branch.


I hereby agree to the terms of the JUnit Contributor License Agreement.


Definition of Done

An NPE was thrown when (de)serializing `TestIdentifiers` without a parent.

Fixes junit-team#3819.

Co-authored-by: Marc Philipp <mail@marcphilipp.de>
@sbrannen sbrannen changed the title Fix NPE when deserializing TestIdentifier Fix NullPointerException when deserializing TestIdentifier May 31, 2024
@sbrannen sbrannen changed the title Fix NullPointerException when deserializing TestIdentifier Avoid NullPointerException when deserializing TestIdentifier May 31, 2024
@holly-cummins
Copy link

I think this PR can be closed because of d29e3eb (and #3838).

@marcphilipp
Copy link
Member

You're right! Thanks for the pointer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants