-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reinstate changes to use JBoss serializer instead of xstream #40906
Conversation
Thanks for your pull request! The title of your pull request does not follow our editorial rules. Could you have a look?
This message is automatically generated by a bot. |
This comment has been minimized.
This comment has been minimized.
a712fe9
to
e758b4b
Compare
🎉 🎉 Will update to that level in this PR and see how CI goes (did we get the backport?) |
Yeah it should include the backport we need. |
e758b4b
to
5836ffe
Compare
PR amended to use JUnit 5.10.3. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, obviously :)
The test failure is definitely related: 2024-06-27T22:31:00.7017409Z Press [e] to edit command line args (currently ''), [r] to re-run, [o] Toggle test output, [h] for more options>
2024-06-27T22:31:00.7019039Z 2024-06-27 22:31:00,573 ERROR [io.qua.test] (Test runner thread) ==================== TEST REPORT #1 ====================
2024-06-27T22:31:00.7020830Z 2024-06-27 22:31:00,574 ERROR [io.qua.test] (Test runner thread) Test TemplatedQuarkusTest#[@io.quarkus.test.junit.QuarkusTest()] failed
2024-06-27T22:31:00.7022050Z : java.lang.ExceptionInInitializerError
2024-06-27T22:31:00.7022979Z at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:499)
2024-06-27T22:31:00.7024208Z at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:480)
2024-06-27T22:31:00.7025819Z at org.jboss.marshalling.reflect.SerializableClass.invokeConstructorNoException(SerializableClass.java:404)
2024-06-27T22:31:00.7027534Z at org.jboss.marshalling.reflect.SerializableClass.callNonInitConstructor(SerializableClass.java:372)
2024-06-27T22:31:00.7029013Z at org.jboss.marshalling.cloner.SerializingCloner.clone(SerializingCloner.java:309)
2024-06-27T22:31:00.7030301Z at org.jboss.marshalling.cloner.SerializingCloner.clone(SerializingCloner.java:132)
2024-06-27T22:31:00.7031660Z at org.jboss.marshalling.cloner.SerializingCloner.cloneFields(SerializingCloner.java:452)
2024-06-27T22:31:00.7033155Z at org.jboss.marshalling.cloner.SerializingCloner.initSerializableClone(SerializingCloner.java:372)
2024-06-27T22:31:00.7034614Z at org.jboss.marshalling.cloner.SerializingCloner.clone(SerializingCloner.java:315)
2024-06-27T22:31:00.7036045Z at org.jboss.marshalling.cloner.SerializingCloner.clone(SerializingCloner.java:132)
2024-06-27T22:31:00.7037450Z at org.jboss.marshalling.cloner.SerializingCloner$StepObjectInput.doReadObject(SerializingCloner.java:930)
2024-06-27T22:31:00.7038955Z at org.jboss.marshalling.AbstractObjectInput.readObject(AbstractObjectInput.java:41)
2024-06-27T22:31:00.7040462Z at org.jboss.marshalling.MarshallerObjectInputStream.readObjectOverride(MarshallerObjectInputStream.java:53)
2024-06-27T22:31:00.7042912Z at java.base/java.io.ObjectInputStream.readObject(ObjectInputStream.java:500)
2024-06-27T22:31:00.7044111Z at java.base/java.io.ObjectInputStream.readObject(ObjectInputStream.java:467)
2024-06-27T22:31:00.7045326Z at java.base/java.util.ArrayList.readObject(ArrayList.java:899)
2024-06-27T22:31:00.7046513Z at org.jboss.marshalling.reflect.JDKSpecific$SerMethods.callReadObject(JDKSpecific.java:171)
2024-06-27T22:31:00.7047969Z at org.jboss.marshalling.reflect.SerializableClass.callReadObject(SerializableClass.java:252)
2024-06-27T22:31:00.7049590Z at org.jboss.marshalling.cloner.SerializingCloner.initSerializableClone(SerializingCloner.java:366)
2024-06-27T22:31:00.7051145Z at org.jboss.marshalling.cloner.SerializingCloner.clone(SerializingCloner.java:315)
2024-06-27T22:31:00.7052507Z at org.jboss.marshalling.cloner.SerializingCloner.clone(SerializingCloner.java:132)
2024-06-27T22:31:00.7054069Z at org.jboss.marshalling.cloner.SerializingCloner.cloneFields(SerializingCloner.java:452)
2024-06-27T22:31:00.7055734Z at org.jboss.marshalling.cloner.SerializingCloner.initSerializableClone(SerializingCloner.java:372)
2024-06-27T22:31:00.7057225Z at org.jboss.marshalling.cloner.SerializingCloner.clone(SerializingCloner.java:315)
2024-06-27T22:31:00.7058675Z at org.jboss.marshalling.cloner.SerializingCloner.clone(SerializingCloner.java:132)
2024-06-27T22:31:00.7060297Z at org.jboss.marshalling.cloner.SerializingCloner$StepObjectInput.doReadObject(SerializingCloner.java:930)
2024-06-27T22:31:00.7061824Z at org.jboss.marshalling.AbstractObjectInput.readObject(AbstractObjectInput.java:41)
2024-06-27T22:31:00.7063427Z at org.jboss.marshalling.MarshallerObjectInputStream.readObjectOverride(MarshallerObjectInputStream.java:53)
2024-06-27T22:31:00.7064929Z at java.base/java.io.ObjectInputStream.readObject(ObjectInputStream.java:500)
2024-06-27T22:31:00.7066255Z at java.base/java.io.ObjectInputStream.readObject(ObjectInputStream.java:467)
2024-06-27T22:31:00.7067387Z at java.base/java.util.ArrayList.readObject(ArrayList.java:899)
2024-06-27T22:31:00.7068559Z at org.jboss.marshalling.reflect.JDKSpecific$SerMethods.callReadObject(JDKSpecific.java:171)
2024-06-27T22:31:00.7070045Z at org.jboss.marshalling.reflect.SerializableClass.callReadObject(SerializableClass.java:252)
2024-06-27T22:31:00.7071659Z at org.jboss.marshalling.cloner.SerializingCloner.initSerializableClone(SerializingCloner.java:366)
2024-06-27T22:31:00.7073166Z at org.jboss.marshalling.cloner.SerializingCloner.clone(SerializingCloner.java:315)
2024-06-27T22:31:00.7074498Z at org.jboss.marshalling.cloner.SerializingCloner.clone(SerializingCloner.java:132)
2024-06-27T22:31:00.7076010Z at org.jboss.marshalling.cloner.SerializingCloner.cloneFields(SerializingCloner.java:452)
2024-06-27T22:31:00.7077533Z at org.jboss.marshalling.cloner.SerializingCloner.initSerializableClone(SerializingCloner.java:372)
2024-06-27T22:31:00.7079009Z at org.jboss.marshalling.cloner.SerializingCloner.clone(SerializingCloner.java:315)
2024-06-27T22:31:00.7080360Z at org.jboss.marshalling.cloner.SerializingCloner.clone(SerializingCloner.java:132)
2024-06-27T22:31:00.7081769Z at org.jboss.marshalling.cloner.SerializingCloner.cloneFields(SerializingCloner.java:452)
2024-06-27T22:31:00.7083329Z at org.jboss.marshalling.cloner.SerializingCloner.initSerializableClone(SerializingCloner.java:372)
2024-06-27T22:31:00.7084856Z at org.jboss.marshalling.cloner.SerializingCloner.clone(SerializingCloner.java:315)
2024-06-27T22:31:00.7086329Z at org.jboss.marshalling.cloner.SerializingCloner.clone(SerializingCloner.java:132)
2024-06-27T22:31:00.7087714Z at org.jboss.marshalling.cloner.SerializingCloner.cloneFields(SerializingCloner.java:452)
2024-06-27T22:31:00.7089280Z at org.jboss.marshalling.cloner.SerializingCloner.initSerializableClone(SerializingCloner.java:372)
2024-06-27T22:31:00.7090832Z at org.jboss.marshalling.cloner.SerializingCloner.clone(SerializingCloner.java:315)
2024-06-27T22:31:00.7092327Z at org.jboss.marshalling.cloner.SerializingCloner.clone(SerializingCloner.java:132)
2024-06-27T22:31:00.7093882Z at org.jboss.marshalling.cloner.SerializingCloner$StepObjectInput.doReadObject(SerializingCloner.java:930)
2024-06-27T22:31:00.7095617Z at org.jboss.marshalling.AbstractObjectInput.readObject(AbstractObjectInput.java:41)
2024-06-27T22:31:00.7097291Z at org.jboss.marshalling.MarshallerObjectInputStream.readObjectOverride(MarshallerObjectInputStream.java:53)
2024-06-27T22:31:00.7098833Z at java.base/java.io.ObjectInputStream.readObject(ObjectInputStream.java:500)
2024-06-27T22:31:00.7100050Z at java.base/java.io.ObjectInputStream.readObject(ObjectInputStream.java:467)
2024-06-27T22:31:00.7101144Z at java.base/java.util.ArrayList.readObject(ArrayList.java:899)
2024-06-27T22:31:00.7102344Z at org.jboss.marshalling.reflect.JDKSpecific$SerMethods.callReadObject(JDKSpecific.java:171)
2024-06-27T22:31:00.7103975Z at org.jboss.marshalling.reflect.SerializableClass.callReadObject(SerializableClass.java:252)
2024-06-27T22:31:00.7105627Z at org.jboss.marshalling.cloner.SerializingCloner.initSerializableClone(SerializingCloner.java:366)
2024-06-27T22:31:00.7107059Z at org.jboss.marshalling.cloner.SerializingCloner.clone(SerializingCloner.java:315)
2024-06-27T22:31:00.7108415Z at org.jboss.marshalling.cloner.SerializingCloner.clone(SerializingCloner.java:132)
2024-06-27T22:31:00.7109774Z at org.jboss.marshalling.cloner.SerializingCloner.cloneFields(SerializingCloner.java:452)
2024-06-27T22:31:00.7111251Z at org.jboss.marshalling.cloner.SerializingCloner.initSerializableClone(SerializingCloner.java:372)
2024-06-27T22:31:00.7112756Z at org.jboss.marshalling.cloner.SerializingCloner.clone(SerializingCloner.java:315)
2024-06-27T22:31:00.7114105Z at org.jboss.marshalling.cloner.SerializingCloner.clone(SerializingCloner.java:132)
2024-06-27T22:31:00.7115795Z at org.jboss.marshalling.cloner.SerializingCloner.cloneFields(SerializingCloner.java:452)
2024-06-27T22:31:00.7116808Z at org.jboss.marshalling.cloner.SerializingCloner.initSerializableClone(SerializingCloner.java:372)
2024-06-27T22:31:00.7117659Z at org.jboss.marshalling.cloner.SerializingCloner.clone(SerializingCloner.java:315)
2024-06-27T22:31:00.7118421Z at org.jboss.marshalling.cloner.SerializingCloner.clone(SerializingCloner.java:132)
2024-06-27T22:31:00.7119301Z at org.jboss.marshalling.cloner.SerializingCloner$StepObjectInput.doReadObject(SerializingCloner.java:930)
2024-06-27T22:31:00.7120174Z at org.jboss.marshalling.AbstractObjectInput.readObject(AbstractObjectInput.java:41)
2024-06-27T22:31:00.7121079Z at org.jboss.marshalling.MarshallerObjectInputStream.readObjectOverride(MarshallerObjectInputStream.java:53)
2024-06-27T22:31:00.7121939Z at java.base/java.io.ObjectInputStream.readObject(ObjectInputStream.java:500)
2024-06-27T22:31:00.7122625Z at java.base/java.io.ObjectInputStream.readObject(ObjectInputStream.java:467)
2024-06-27T22:31:00.7123238Z at java.base/java.util.ArrayList.readObject(ArrayList.java:899)
2024-06-27T22:31:00.7123926Z at org.jboss.marshalling.reflect.JDKSpecific$SerMethods.callReadObject(JDKSpecific.java:171)
2024-06-27T22:31:00.7124765Z at org.jboss.marshalling.reflect.SerializableClass.callReadObject(SerializableClass.java:252)
2024-06-27T22:31:00.7125882Z at org.jboss.marshalling.cloner.SerializingCloner.initSerializableClone(SerializingCloner.java:366)
2024-06-27T22:31:00.7126723Z at org.jboss.marshalling.cloner.SerializingCloner.clone(SerializingCloner.java:315)
2024-06-27T22:31:00.7127479Z at org.jboss.marshalling.cloner.SerializingCloner.clone(SerializingCloner.java:132)
2024-06-27T22:31:00.7128298Z at org.jboss.marshalling.cloner.SerializingCloner.cloneFields(SerializingCloner.java:452)
2024-06-27T22:31:00.7129176Z at org.jboss.marshalling.cloner.SerializingCloner.initSerializableClone(SerializingCloner.java:372)
2024-06-27T22:31:00.7130016Z at org.jboss.marshalling.cloner.SerializingCloner.clone(SerializingCloner.java:315)
2024-06-27T22:31:00.7130878Z at org.jboss.marshalling.cloner.SerializingCloner.clone(SerializingCloner.java:132)
2024-06-27T22:31:00.7131670Z at org.jboss.marshalling.cloner.SerializingCloner.cloneFields(SerializingCloner.java:452)
2024-06-27T22:31:00.7132544Z at org.jboss.marshalling.cloner.SerializingCloner.initSerializableClone(SerializingCloner.java:372)
2024-06-27T22:31:00.7133473Z at org.jboss.marshalling.cloner.SerializingCloner.initSerializableClone(SerializingCloner.java:340)
2024-06-27T22:31:00.7134314Z at org.jboss.marshalling.cloner.SerializingCloner.clone(SerializingCloner.java:315)
2024-06-27T22:31:00.7135058Z at org.jboss.marshalling.cloner.SerializingCloner.clone(SerializingCloner.java:132)
2024-06-27T22:31:00.7136132Z at org.jboss.marshalling.cloner.SerializingCloner.cloneFields(SerializingCloner.java:452)
2024-06-27T22:31:00.7137094Z at org.jboss.marshalling.cloner.SerializingCloner.initSerializableClone(SerializingCloner.java:372)
2024-06-27T22:31:00.7138091Z at org.jboss.marshalling.cloner.SerializingCloner.initSerializableClone(SerializingCloner.java:340)
2024-06-27T22:31:00.7138927Z at org.jboss.marshalling.cloner.SerializingCloner.clone(SerializingCloner.java:315)
2024-06-27T22:31:00.7139665Z at org.jboss.marshalling.cloner.SerializingCloner.clone(SerializingCloner.java:132)
2024-06-27T22:31:00.7140494Z at org.jboss.marshalling.cloner.SerializingCloner.cloneFields(SerializingCloner.java:452)
2024-06-27T22:31:00.7141410Z at org.jboss.marshalling.cloner.SerializingCloner.initSerializableClone(SerializingCloner.java:372)
2024-06-27T22:31:00.7142321Z at org.jboss.marshalling.cloner.SerializingCloner.initSerializableClone(SerializingCloner.java:340)
2024-06-27T22:31:00.7143162Z at org.jboss.marshalling.cloner.SerializingCloner.clone(SerializingCloner.java:315)
2024-06-27T22:31:00.7143902Z at org.jboss.marshalling.cloner.SerializingCloner.clone(SerializingCloner.java:132)
2024-06-27T22:31:00.7144725Z at io.quarkus.test.junit.internal.NewSerializingDeepClone.clone(NewSerializingDeepClone.java:92)
2024-06-27T22:31:00.7145795Z at io.quarkus.test.junit.QuarkusTestExtension.runExtensionMethod(QuarkusTestExtension.java:965)
2024-06-27T22:31:00.7146668Z at io.quarkus.test.junit.QuarkusTestExtension.runExtensionMethod(QuarkusTestExtension.java:905)
2024-06-27T22:31:00.7147610Z at io.quarkus.test.junit.QuarkusTestExtension.interceptTestTemplateMethod(QuarkusTestExtension.java:865)
2024-06-27T22:31:00.7148462Z at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:183)
2024-06-27T22:31:00.7149195Z at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197)
2024-06-27T22:31:00.7149941Z at java.base/java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:179)
2024-06-27T22:31:00.7150655Z at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197)
2024-06-27T22:31:00.7151418Z at java.base/java.util.stream.Streams$StreamBuilderImpl.forEachRemaining(Streams.java:411)
2024-06-27T22:31:00.7152197Z at java.base/java.util.stream.ReferencePipeline$Head.forEach(ReferencePipeline.java:762)
2024-06-27T22:31:00.7152943Z at java.base/java.util.stream.ReferencePipeline$7$1.accept(ReferencePipeline.java:276)
2024-06-27T22:31:00.7153738Z at java.base/java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1625)
2024-06-27T22:31:00.7154506Z at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:509)
2024-06-27T22:31:00.7155423Z at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499)
2024-06-27T22:31:00.7156217Z at java.base/java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:150)
2024-06-27T22:31:00.7157016Z at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:173)
2024-06-27T22:31:00.7157794Z at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
2024-06-27T22:31:00.7158531Z at java.base/java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:596)
2024-06-27T22:31:00.7159208Z at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
2024-06-27T22:31:00.7159726Z at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
2024-06-27T22:31:00.7160257Z Caused by: java.util.NoSuchElementException: No value present
2024-06-27T22:31:00.7160740Z at java.base/java.util.Optional.get(Optional.java:143)
2024-06-27T22:31:00.7161386Z at io.quarkus.deployment.dev.testing.TestConsoleHandler.<clinit>(TestConsoleHandler.java:38)
2024-06-27T22:31:00.7161942Z ... 117 more
2024-06-27T22:31:00.7162066Z
2024-06-27T22:31:00.7162610Z 2024-06-27 22:31:00,582 ERROR [io.qua.test] (Test runner thread) >>>>>>>>>>>>>>>>>>>> Summary: <<<<<<<<<<<<<<<<<<<<
2024-06-27T22:31:00.7163302Z TemplatedQuarkusTest#[@io.quarkus.test.junit.QuarkusTest()] null
2024-06-27T22:31:00.7164100Z 2024-06-27 22:31:00,585 ERROR [io.qua.test] (Test runner thread) >>>>>>>>>>>>>>>>>>>> 1 TEST FAILED <<<<<<<<<<<<<<<<<<<<
2024-06-27T22:31:00.7164947Z 1 test failed (2 passing, 0 skipped), 3 tests were run in 2656ms. Tests completed at 22:31:00.
2024-06-27T22:31:08.6068071Z [ERROR] Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 32.81 s <<< FAILURE! -- in io.quarkus.it.extension.it.TestTemplateDevModeIT
2024-06-27T22:31:08.6069789Z [ERROR] io.quarkus.it.extension.it.TestTemplateDevModeIT.testThatTheTestsPassed -- Time elapsed: 32.81 s <<< FAILURE!
2024-06-27T22:31:08.6070735Z org.opentest4j.AssertionFailedError: expected: <0> but was: <1>
2024-06-27T22:31:08.6071439Z at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
2024-06-27T22:31:08.6072865Z at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
2024-06-27T22:31:08.6074205Z at org.junit.jupiter.api.AssertEquals.failNotEqual(AssertEquals.java:197)
2024-06-27T22:31:08.6075342Z at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:166)
2024-06-27T22:31:08.6076036Z at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:161)
2024-06-27T22:31:08.6076689Z at org.junit.jupiter.api.Assertions.assertEquals(Assertions.java:632)
2024-06-27T22:31:08.6077505Z at io.quarkus.it.extension.it.TestTemplateDevModeIT.testThatTheTestsPassed(TestTemplateDevModeIT.java:59)
2024-06-27T22:31:08.6078281Z at java.base/java.lang.reflect.Method.invoke(Method.java:568)
2024-06-27T22:31:08.6078807Z at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
2024-06-27T22:31:08.6079312Z at java.base/java.util.ArrayList.forEach(ArrayList.java:1511) |
Yeah, that test failure is the one we'd expect if @dmlloyd's fix hadn't been backported. It's hard to tell if it's been backported or not. Confusing! But ... if I check https://github.com/junit-team/junit5/commits/releases/5.10.x/, I can see 3820 in there, which would be consistent with them just doing the backport themselves. So then the question is ... why is 5.10.3 + these changes regressing that test? :( |
I've checked #40773, and the stack trace is a bit different. Without 5.10.3, the stack trace is:
So this is definitely a regression, and one that seems related to either 5.10.3 or #40601, but more investigation will be needed. We can apply 5.10.3 without #40601, so I'll try that first, just for diagnostics. |
We actually already have it in |
Ah, I looked for the dependabot PR but didn't think to look at the closed ones. I should have remembered how fast you are. :) OK, I'll confirm whether this affects Pact as well (seems likely), confirm I can reproduce locally, and see what I can see. |
Or basically that I am 2 hours ahead in my TZ :P |
I don't think the failure in the CI can be anything to do with these changes. All tests on one machine failed with:
|
Indeed that looks unrelated! You can try running the failing job again just to be on the safe side |
I think that needs higher privileges than I have: https://github.com/quarkusio/quarkus/actions/runs/9724907070/job/26841777161?pr=40906 is the failing job, but I could only re-run it by doing a rebase and re-running everything. |
I kicked it off! |
Hmm, same failure. I'll rebase to trigger a new build, in case the problem was a glitch in the process that farms work out to the matrix sub-builds. |
a08c827
to
6b63320
Compare
Sorry to be the bearer of bad news, but I would be surprised if it was a glitch. Never seen than before and I wouldn't be surprised if it was an actual issue. The IT main thing is a bit of a weird beast (quite large and mixing quite a lot of extensions/patterns). |
What makes me suspect it's a glitch is that it appears to be a packaging issue (the error message claims a file is missing on disk). If a code-level issue in this change affected discoverability of the file, it should affect quite a few sub-builds, not just the one. The failure is across the board in one 'child', but the identical child with virtual threads enabled passes fine, as do all the other native children. This change clones fewer classes than #40601 (which clones a lot more classes than
I'm trying to reproduce locally, but without luck so far; I've given podman machine 4gb and am running with
and my local build is OOMing:
|
This comment has been minimized.
This comment has been minimized.
9ce7c8e
to
79dbbed
Compare
I think we are experiencing this very issue elsewhere: #41561 . |
I think it's related to the Develocity cache extension that is being developed by the Gradle team and @aloubyansky (cc @jprinet). I will have a look. |
While trying to figure out what in my change could have caused this, I ended up doing the follow-on refactoring I wanted to do, to reduce duplication between the checks in the serialization class and I kept support for configuring what classes get cloned, with the Quarkus-set default being |
79dbbed
to
f0f899f
Compare
Ok, clean build: ![]() My amendments on top of the amended version above are f0f899ff905 and I've kicked off a squashed build. |
…#40749" This reverts commit fc3988b. It has some additional changes which re-revert part of quarkusio#40601, to reintroduce removed guards to avoid cloning things like Quarkus runtime classes. Otherwise we get test failures.
f0f899f
to
eef5138
Compare
This comment has been minimized.
This comment has been minimized.
I think this can be merged as soon as CI has passed. I'm not worried about the flaky tests. |
Status for workflow
|
Awesome! |
This reinstates #40601. See discussion in #40880. This PR reintroduces @dmlloyd's lovely #40601, now that JUnit has been updated to a version which is compatible with #40601, 5.10.3.
It also includes a fix for a functional issue in the change that we couldn't see when it was blocked by JUnit problems (and earlier, by a lack of test coverage).