Document how to use CloseableResource
#3840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or an HttpServer resource. Issue: junit-team#1555
pzygielo
reviewed
Jun 1, 2024
| @@ -714,6 +713,26 @@ extension context lifecycle ends it closes its associated store. All stored valu | |||
| that are instances of `CloseableResource` are notified by an invocation of their `close()` | |||
| method in the inverse order they were added in. | |||
|
|
|||
| An example use-case of `ClosableResource` is shown below, using an `HttpServer` resource. | |||
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
pzygielo
reviewed
Jun 1, 2024
SveinKare
changed the title
Issue: junit-team#1555
1 task
sbrannen
changed the title
CloseableResource
1 task
marcphilipp
requested changes
Jul 8, 2024
There was a problem hiding this comment.
Thanks for the PR! 👍
Instead of implementing BeforeAllCallback, I think we should implement ParameterResolver for HttpServer and start the server lazily when it's first being resolved.
@SveinKare Please let me know if you have time to make this change or if you'd like me to take over.
|
@marcphilipp You can go ahead and change it |
marcphilipp
approved these changes
Jul 9, 2024
|
@SveinKare Thanks for taking care of this! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #1555
Overview
Added an explanation in the user guide for how
CloseableResourcecan be used, with an example using anHttpServerresource.I hereby agree to the terms of the JUnit Contributor License Agreement.
Definition of Done
@APIannotations