Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Extension App Aliases to Server App #473

Merged
merged 1 commit into from
Apr 12, 2021

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Apr 12, 2021

Fixes jupyterlab/jupyterlab#10059.

The better long term solution is to pass the CLI args to ExtensionApp itself for parsing, but this will take some consideration for backwards compatibility.

@codecov-io
Copy link

codecov-io commented Apr 12, 2021

Codecov Report

Merging #473 (c7f24a4) into master (5dfdb1d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #473   +/-   ##
=======================================
  Coverage   77.71%   77.71%           
=======================================
  Files         106      106           
  Lines        9136     9137    +1     
  Branches      979      979           
=======================================
+ Hits         7100     7101    +1     
  Misses       1687     1687           
  Partials      349      349           
Impacted Files Coverage Δ
jupyter_server/extension/application.py 72.50% <100.00%> (+0.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5dfdb1d...c7f24a4. Read the comment docs.

Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073 blink1073 added this to the 1.6 milestone Apr 12, 2021
@blink1073 blink1073 merged commit 2756a29 into jupyter-server:master Apr 12, 2021
@jtpio jtpio deleted the server-aliases branch April 12, 2021 15:29
hMED22 pushed a commit to hMED22/jupyter_server that referenced this pull request Jan 23, 2023
Add Extension App Aliases to Server App
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--app-dir not recognized
3 participants